Skip to content

need to clear mark array bits for regions completely outside the marked range in FGCs - #66696

Merged
Maoni0 merged 2 commits into
dotnet:mainfrom
Maoni0:clear_ma
Mar 16, 2022
Merged

Maoni0 merged 2 commits into
dotnet:mainfrom
Maoni0:clear_ma

Conversation

@Maoni0

@Maoni0 Maoni0 commented Mar 16, 2022 •

Copy link
Copy Markdown
Member

we are missing a case where the mark array bits need to be cleared for a region is completely outside the marked range (ie, slow/shigh) in Workstation GC.

also added verification when we return a region to free.

@ghost ghost assigned Maoni0 Mar 16, 2022
@ghost ghost added the area-GC-coreclr label Mar 16, 2022
@ghost

ghost commented Mar 16, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

we are missing a case where the mark array bits need to be cleared for a region/segment is completely outside the marked range (ie, slow/shigh) in Workstation GC.

also added verification when we return a region to free.

Author: Maoni0
Assignees: Maoni0
Labels:

area-GC-coreclr

Milestone: -

@Maoni0

Maoni0 commented Mar 16, 2022

Copy link
Copy Markdown
Member Author

/azp run runtime-coreclr outerloop

@Maoni0

Maoni0 commented Mar 16, 2022

Copy link
Copy Markdown
Member Author

/azp run runtime-libraries-coreclr outerloop-windows

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@Maoni0

Maoni0 commented Mar 16, 2022

Copy link
Copy Markdown
Member Author

/azp run runtime-libraries-coreclr outerloop-linux

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@Maoni0
Maoni0 merged commit 71b6994 into dotnet:main Mar 16, 2022
radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
…ed range in FGCs (dotnet#66696)

we are missing a case where the mark array bits need to be cleared for a region is completely outside the marked range (ie, slow/shigh) in Workstation GC.

also added verification when we return a region to free.
@ghost ghost locked as resolved and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants