Skip to content

Add missing regex position check after BOL optimization - #66216

Merged
stephentoub merged 2 commits into
dotnet:mainfrom
stephentoub:fixbolopt
Mar 7, 2022
Merged

Add missing regex position check after BOL optimization#66216
stephentoub merged 2 commits into
dotnet:mainfrom
stephentoub:fixbolopt

Conversation

@stephentoub

@stephentoub stephentoub commented Mar 4, 2022

Copy link
Copy Markdown
Member

Fixes #66212

@stephentoub stephentoub added this to the 7.0.0 milestone Mar 4, 2022
@stephentoub
stephentoub requested a review from joperezr March 4, 2022 20:44
@ghost ghost assigned stephentoub Mar 4, 2022
@ghost

ghost commented Mar 4, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #66212

Author: stephentoub
Assignees: -
Labels:

area-System.Text.RegularExpressions
Milestone: 7.0.0

joperezr
joperezr approved these changes Mar 4, 2022
View reviewed changes

@joperezr joperezr left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not that I expect it to make a difference, but should we add a test that is actually multi-line like "car\nbar\n" and has more than one match?

@stephentoub

stephentoub commented Mar 4, 2022

Copy link
Copy Markdown
Member Author

Sure

@runfoapp runfoapp Bot mentioned this pull request Mar 4, 2022
Closed
@stephentoub
stephentoub merged commit 277e12b into dotnet:main Mar 7, 2022
@stephentoub
stephentoub deleted the fixbolopt branch March 7, 2022 00:13
@stephentoub stephentoub mentioned this pull request Mar 15, 2022
Closed
@EgorBo

EgorBo commented Mar 17, 2022

Copy link
Copy Markdown
Member

Improvements on win-x64 dotnet/perf-autofiling-issues#3993

@ghost ghost locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@joperezr joperezr joperezr approved these changes

Assignees

@stephentoub stephentoub

Labels

area-System.Text.RegularExpressions

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

Regex Matches Count gives ArgumentOutOfRangeException (regression)

3 participants

@stephentoub @EgorBo @joperezr