Repository navigation
Keep CLSCompliantAttribute in sync for src <-> ref - #66075
Merged
Merged
Conversation
ApiCompat actually ran validation for that attribute until the check was disabled with a675e1c. Enable it again and only disable it for baseline api compat validation, which is performed in ApiCompat.proj.
ghost
added
the 
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsApiCompat actually ran validation for that attribute until the check was Re-enable it and only disable the check during baseline api compat
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #58163
Until two years ago, ApiCompat validated the CLSCompliantAttribute
but that check was then disabled with a675e1c.
Re-enable it and only disable the check during baseline api compat
validation, which is performed in ApiCompat.proj.