Skip to content

Add AggressiveInlining attribute to multi-dimension array helpers #60750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BruceForstall wants to merge 1 commit into from
Closed

Add AggressiveInlining attribute to multi-dimension array helpers #60750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/coreclr/System.Private.CoreLib/src/System/Array.CoreCLR.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,13 +375,15 @@ private unsafe nint GetFlattenedIndex(ReadOnlySpan<int> indices)

public unsafe int Rank
{
[MethodImpl(MethodImplOptions.AggressiveInlining)]
get
{
int rank = RuntimeHelpers.GetMultiDimensionalArrayRank(this);
return (rank != 0) ? rank : 1;
}
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public unsafe int GetLength(int dimension)
{
int rank = RuntimeHelpers.GetMultiDimensionalArrayRank(this);
Expand All @@ -394,6 +396,7 @@ public unsafe int GetLength(int dimension)
return Unsafe.Add(ref RuntimeHelpers.GetMultiDimensionalArrayBounds(this), dimension);
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public unsafe int GetUpperBound(int dimension)
{
int rank = RuntimeHelpers.GetMultiDimensionalArrayRank(this);
Expand All @@ -407,6 +410,7 @@ public unsafe int GetUpperBound(int dimension)
return Unsafe.Add(ref bounds, dimension) + Unsafe.Add(ref bounds, rank + dimension) - 1;
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public unsafe int GetLowerBound(int dimension)
{
int rank = RuntimeHelpers.GetMultiDimensionalArrayRank(this);
Expand Down