Skip to content

Fix PerformanceCounter tests - #60372

Merged
danmoseley merged 2 commits into
dotnet:mainfrom
danmoseley:fix.pc.tests
Oct 14, 2021
Merged

danmoseley merged 2 commits into
dotnet:mainfrom
danmoseley:fix.pc.tests

Conversation

@danmoseley

@danmoseley danmoseley commented Oct 13, 2021 •

Copy link
Copy Markdown
Contributor

Fix #45182
Fix #54943

This has failed sporadically since these tests were written 4 years ago. On investigating I found that counter names and category names were intermingled, sometimes with the opposite names.
Changed to use consistent variable names and actual names. Added asserts. Moved deleting categories to after disposing the counter. Add retries on deleting category. Fix a few comments.

Fix #29753

Change to use a counter less likely to be zero, and retry it.

@ghost

ghost commented Oct 13, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #45182
Fix #54943

This has failed sporadically since these tests were written 4 years ago. On investigating I found that counter names and category names were intermingled, sometimes with the opposite names.
Changed to use consistent variable names and actual names. Added asserts. Moved deleting categories to after disposing the counter. Add retries on deleting category. Fix a few comments.

Author: danmoseley
Assignees: -
Labels:

area-System.Diagnostics.Tracing

Milestone: -

@danmoseley

Copy link
Copy Markdown
Contributor Author

@steveisok Build tvOSSimulator x64 Release AllSubsets_Mono timed out. It says after 3 hours, but I think it's because the build took 80 minutes.

@danmoseley
danmoseley merged commit 1ebec9a into dotnet:main Oct 14, 2021
@danmoseley
danmoseley deleted the fix.pc.tests branch October 14, 2021 04:44
@ghost ghost locked as resolved and limited conversation to collaborators Nov 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

2 participants