Repository navigation
Fix PerformanceCounter tests - #60372
Merged
Merged
Conversation
|
Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti Issue DetailsThis has failed sporadically since these tests were written 4 years ago. On investigating I found that counter names and category names were intermingled, sometimes with the opposite names.
|
tarekgh
approved these changes
Oct 13, 2021
Contributor
Author
|
@steveisok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #45182
Fix #54943
This has failed sporadically since these tests were written 4 years ago. On investigating I found that counter names and category names were intermingled, sometimes with the opposite names.
Changed to use consistent variable names and actual names. Added asserts. Moved deleting categories to after disposing the counter. Add retries on deleting category. Fix a few comments.
Fix #29753
Change to use a counter less likely to be zero, and retry it.