Skip to content

make Quic AcceptStreamAsync concurrent safe #56768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wfurt merged 2 commits into from
Aug 4, 2021
Merged

make Quic AcceptStreamAsync concurrent safe #56768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b482c4
make AcceptStreamAsync concurrent safe
wfurt Aug 3, 2021
faa04fc
feedback from review
wfurt Aug 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ internal sealed class State
// Backlog limit is managed by MsQuic so it can be unbounded here.
public readonly Channel<MsQuicStream> AcceptQueue = Channel.CreateUnbounded<MsQuicStream>(new UnboundedChannelOptions()
{
SingleReader = true,
SingleWriter = true,
Comment thread
wfurt marked this conversation as resolved.
});

Expand Down
29 changes: 29 additions & 0 deletions src/libraries/System.Net.Quic/tests/FunctionalTests/QuicStreamTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,35 @@ await RunClientServer(
);
}

[Fact]
public async Task MultipleConcurrentStreamsOnSingleConnection()
{
const int count = 100;
Task[] tasks = new Task[count];

(QuicConnection clientConnection, QuicConnection serverConnection) = await CreateConnectedQuicConnection();
using (clientConnection)
using (serverConnection)
{
for (int i = 0; i < count; i++)
{
tasks[i] = MakeStreams(clientConnection, serverConnection);
}
await tasks.WhenAllOrAnyFailed(PassingTestTimeoutMilliseconds);
}

static async Task MakeStreams(QuicConnection clientConnection, QuicConnection serverConnection)
{
byte[] buffer = new byte[64];
QuicStream clientStream = clientConnection.OpenBidirectionalStream();
ValueTask writeTask = clientStream.WriteAsync(Encoding.UTF8.GetBytes("PING"), endStream: true);
ValueTask<QuicStream> acceptTask = serverConnection.AcceptStreamAsync();
await new Task[] { writeTask.AsTask(), acceptTask.AsTask()}.WhenAllOrAnyFailed(PassingTestTimeoutMilliseconds);
QuicStream serverStream = acceptTask.Result;
await serverStream.ReadAsync(buffer);
}
}

[Fact]
public async Task GetStreamIdWithoutStartWorks()
{
Expand Down