Repository navigation
Replace Values with KeyValuePair enumerator in MemoryCache - #53762
Merged
Merged
Conversation
Changed code to use KeyValuePair enumerator
Update MemoryCache to use KeyValuePair enumerator from concurrent dictionary
|
Tagging subscribers to this area: @eerhardt, @maryamariyan, @michaelgsharp Issue DetailsConcurrentDictionary.Values will lock all the locks in the MemoryCache internal _entries ConcurrentDictionary .
|
eerhardt
reviewed
Jun 7, 2021
Contributor
Author
|
Related issue: |
Contributor
Author
|
@martincostello @eerhardt any other comments? |
adamsitnik
approved these changes
Jun 10, 2021
adamsitnik
left a comment
adamsitnik
left a comment
Member
There was a problem hiding this comment.
LGTM, thank you @ezgambac !
edevoogd
added a commit
to edevoogd/runtime
that referenced
this pull request
Jun 21, 2021
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConcurrentDictionary.Values will lock all the locks in the MemoryCache internal _entries ConcurrentDictionary .
However, using regular dictionary enumerator which returns a KeyValuePair<TKey, TValue> does not cause locking.
This is important in heavy throughput scenarios as accessing .Values could reduce write throughput for the MemoryCache.