Repository navigation
Small fixed error in code - #51821
Merged
Merged
Conversation
If def DISPLAY_SIZES = 1 in jit.h, then gives and error
If def DISPLAY_SIZES = 1, gives an error
ghost
added
the
area-CodeGen-coreclr
|
|
because of intersection of names "dataSize" between "compiler.h" and in "codegenarm64.cpp"
BruceForstall
self-requested a review
April 29, 2021 01:54
Contributor
Author
sandreenko
reviewed
May 5, 2021
sandreenko
left a comment
sandreenko
left a comment
Contributor
There was a problem hiding this comment.
Fixed the type declaration for dataSize(because of 2523-2524 line doesn't see the declaration of this variable in "codegencommon.cpp"). Correct me, if i'm wrong
Is there an issue if we move
size_t dataSize = GetEmitter()->emitDataSize();
from genEmitMachineCode to the next function instead of declaring it globally?
and revert eDataSize after.
transfer local declaration for dataSize
sandreenko
approved these changes
May 5, 2021
sandreenko
left a comment
sandreenko
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thank you for restoring CALL_ARG_STATS and DISPLAY_SIZES .
Contributor
|
cc @dotnet/jit-contrib |
Contributor
|
The failures are unrelated, covered by https://statics.teams.cdn.office.net/evergreen-assets/safelinks/1/atp-safelinks.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If define CALL_ARG_STATS = 1 and DISPLAY_SIZES = 1 in "jit.h", then will be compilation errors