[cshung]

In 2019, we introduced the large page support in the GC. However, this feature is not regularly tested, and we found it broken (and fixed) once in a while due to careless changes.

It is time for us to introduce automated testing to avoid future regression. I have got some initial pointers from @Maoni0 and @safern. Here I am just bootstrapping the effort, as one can see, the change is kinda empty since I am not sure what to do there.

From the GC's perspective, the large page support only changes how the GC interacts with the operating system in terms of how memory pages are acquired. Therefore, it is not particularly meaningful to run many tests. A handful of tests that exercise the various hard limits config and do some simple allocation would do.

Here are the two things that need to happen:

• To only run tests on windows amd64 machines with the SeLockMemoryPrivilege enabled (I knew some infrastructure work is already done to enable the privilege), and
• To specify some COMPLUS variables so tests can pick it to do the specific large page testing when we need it.

[ghost]

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

[ghost]

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

---

In 2019, we introduced the large page support in the GC. However, this feature is not regularly tested, and we found it broken (and fixed) once in a while due to careless changes.

It is time for us to introduce automated testing to avoid future regression. I have got some initial pointers from @Maoni0 and @safern. Here I am just bootstrapping the effort, as one can see, the change is kinda empty since I am not sure what to do there.

From the GC's perspective, the large page support only changes how the GC interacts with the operating system in terms of how memory pages are acquired. Therefore, it is not particularly meaningful to run many tests. A handful of tests that exercise the various hard limits config and do some simple allocation would do.

The key challenge to this work is that the tests will require special machines (e.g. on Windows, we will need the SeLockMemoryPrivilege). That is why I need to make these changes.

Author:	cshung
Assignees:	-
Labels:	area-GC-coreclr
Milestone:	-

[Maoni0]

I don't think I understand this part -

The key challenge to this work is that the tests will require special machines (e.g. on Windows, we will need the SeLockMemoryPrivilege). That is why I need to make these changes.

this change was already there as I mentioned on Teams. the work that's left is to add the GCLargePages env var so tests can pick it and run with it.

[safern]

cc: @BruceForstall

[BruceForstall]

I don't think you should add this to the "gcstress-extra" job. You should create a new job. E.g., there already is gc-longrunning and gc-simulator (I don't know if they actually run).

You should change eng\pipelines\common\templates\runtimes\run-test-job.yml. The eng\pipelines\libraries-run-test-job.yml is used (by coreclr testing) for running coreclr stress tests over the libraries test assets.

[safern]

You probably want to add a helixQueueGroup for this as well so that we only run this tests in the windows helix queue that has this support enabled.

https://github.com/dotnet/runtime/blob/7810035f31bfd4e2f5d83cc405cf9307d346d77c/eng/pipelines/coreclr/templates/helix-queues-setup.yml#L117

[cshung]

We will continue this work on #51255