Inline and delete runtime.$(os).$(proj).props files

[am11]

Fixes #37241.

[ghost]

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

[am11]

cc @jkotas, something like this?

[jkotas]

LGTM. Thanks

[dagood]

This is something I've wanted to investigate doing for a while, but never had a reason to--now that we're adding more platforms, good time. I'm not aware of any reasons not to do this (but would rather leave in-depth review to others more involved with these changes). 👍

[am11]

CoreCLR Pri0 Runtime Tests Run Windows_NT arm checked is unrelated to PR changes, related issue: #37132.

[AaronRobinsonMSFT]

@am11 I believe this has broken shipping the static lib on Windows #35616 (comment).

[am11]

We were including libnethost.lib as well as nethost.lib on Windows before this change. This PR generalizes it and only includes nethost.lib via this pattern:

<NativeBinary Include="$(DotNetHostBinDir)/$(LibraryFilePrefix)nethost$(StaticLibraryFileExtension)" />

(on Windows LibraryFilePrefix is empty)

do we need both files or is nethost.lib completely different?

[AaronRobinsonMSFT]

@am11 Yes we need both. This is a common issue on Windows since both a static lib and import lib use the same extension (i.e. *.lib). In this case, nethost.lib is the import lib for consuming nethost.dll and libnethost.lib is the static version of the nethost binary. I would imagine that on non-Windows this mistake wasn't made.

[am11]

OK, i have added it in #37878. Yes, before it was:

Windows
-    <ArchitectureSpecificNativeFile Include="$(DotNetHostBinDir)/libnethost.lib" />
-    <ArchitectureSpecificNativeFile Include="$(DotNetHostBinDir)/nethost.lib" />
non-Windows
-    <ArchitectureSpecificNativeFile Include="$(DotNetHostBinDir)/libnethost.a" />

this change only effects Windows case, and only nethost had this specific case. ijwhost.lib and comhost.lib etc. had only one variant, without lib prefix.

[AaronRobinsonMSFT]

this change only effects Windows case, and only nethost had this specific case. ijwhost.lib and comhost.lib etc. had only one variant, without lib prefix.

Yes, that is true. We only ship a static lib for the nethost scenario.