Skip to content

Revert "Revert "Switch reverse PInvoke to the NativeCallable plan"" - #34315

Merged
jkotas merged 1 commit into
dotnet:masterfrom
jkotas:nativecallable
Apr 1, 2020
Merged

jkotas merged 1 commit into
dotnet:masterfrom
jkotas:nativecallable

Conversation

@jkotas

@jkotas jkotas commented Mar 31, 2020 •

Copy link
Copy Markdown
Member

Fix #33581

@Dotnet-GitSync-Bot

Copy link
Copy Markdown
Collaborator

I couldn't figure out the best area label to add to this PR. Please help me learn by adding exactly one area label.

@jkotas jkotas changed the title Revert "Revert "Switch reverse PInvoke to the NativeCallable plan" WIP: Revert "Revert "Switch reverse PInvoke to the NativeCallable plan" Mar 31, 2020
@AaronRobinsonMSFT

Copy link
Copy Markdown
Member

@jkotas I see a file name change in this review. Was there was something else that changed between this and the original one?

@jkotas

jkotas commented Mar 31, 2020

Copy link
Copy Markdown
Member Author

It is to trigger full run of libraries tests

@jkotas
jkotas force-pushed the nativecallable branch 2 times, most recently from 80c88ef to b06710e Compare March 31, 2020 15:35
@jkotas
jkotas force-pushed the nativecallable branch 3 times, most recently from 484a00c to fc42284 Compare April 1, 2020 02:20
@jkotas jkotas changed the title WIP: Revert "Revert "Switch reverse PInvoke to the NativeCallable plan" Revert "Revert "Switch reverse PInvoke to the NativeCallable plan"" Apr 1, 2020
@jkotas

jkotas commented Apr 1, 2020

Copy link
Copy Markdown
Member Author

Passed CI with an extra dummy commit to trigger libraries run.

@jkotas
jkotas merged commit 676cb17 into dotnet:master Apr 1, 2020
@jkotas
jkotas deleted the nativecallable branch April 1, 2020 20:25
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove UMThunkStub for all non-x86 scenarios

3 participants