Repository navigation
Conversation
…ect interior insertions Document.GetTextChangesAsync can return scattered non-minimal edits for a single extern fix (e.g. RuntimeHandles.GetMethodDef in CoreLib), which then overlapped with the edit of a neighboring diagnostic and made SourceText.WithChanges throw 'The changes must not overlap', silently dropping every CS9389 fix in the file. Diff by trimming the common prefix/suffix instead, and treat an insertion inside another edit as a conflict. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 516325d9-9475-4e86-88ca-7b28389c6572
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 516325d9-9475-4e86-88ca-7b28389c6572
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 516325d9-9475-4e86-88ca-7b28389c6572
…on driver (untouched output) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 516325d9-9475-4e86-88ca-7b28389c6572
…he migration driver (untouched output) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 516325d9-9475-4e86-88ca-7b28389c6572
…gration driver (untouched output) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 516325d9-9475-4e86-88ca-7b28389c6572
…e migration driver (untouched output) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 516325d9-9475-4e86-88ca-7b28389c6572
…ion driver (untouched output) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 516325d9-9475-4e86-88ca-7b28389c6572
… the migration driver (untouched output) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 516325d9-9475-4e86-88ca-7b28389c6572
…ration driver (untouched output) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 516325d9-9475-4e86-88ca-7b28389c6572
…h the migration driver (untouched output) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 516325d9-9475-4e86-88ca-7b28389c6572
…uched output) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 516325d9-9475-4e86-88ca-7b28389c6572
…er (untouched output) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 516325d9-9475-4e86-88ca-7b28389c6572
…driver (untouched output) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 516325d9-9475-4e86-88ca-7b28389c6572
…gration driver (untouched output) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 516325d9-9475-4e86-88ca-7b28389c6572
…Variables It compiles the shared ValueStringBuilder, which now contains unsafe blocks under unsafe-v2. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 516325d9-9475-4e86-88ca-7b28389c6572
…0 and later Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 516325d9-9475-4e86-88ca-7b28389c6572
… (untouched output) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 516325d9-9475-4e86-88ca-7b28389c6572
…2 with the migration driver (untouched output) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 516325d9-9475-4e86-88ca-7b28389c6572
…th the migration driver (untouched output) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 516325d9-9475-4e86-88ca-7b28389c6572
… migration driver (untouched output) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 516325d9-9475-4e86-88ca-7b28389c6572
…v2 with the migration driver (untouched output) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 516325d9-9475-4e86-88ca-7b28389c6572
…n driver (untouched output) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 516325d9-9475-4e86-88ca-7b28389c6572
…ation driver (untouched output) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 516325d9-9475-4e86-88ca-7b28389c6572
It compiles extern declarations that now need an explicit unsafe contract. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 516325d9-9475-4e86-88ca-7b28389c6572
…th the migration driver (untouched output) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 516325d9-9475-4e86-88ca-7b28389c6572
|
Azure Pipelines: Successfully started running 3 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/interop-contrib |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enrolls the Microsoft.* libraries and their tests in unsafe-v2 for net11.0 and later and applies the output of the migration driver, one commit per project, untouched.
MemorySafetyRulesVersion=2for net11.0+ in 43 libraries and 44 test project files. net10.0 and older keep the legacy rules: the LibraryImportGenerator in those targeting packs stampsunsafeon generated types, an unfixableCS9377under the new rules.Microsoft.Bcl.*is not included.Microsoft.Extensions.Configuration.EnvironmentVariablesandMicrosoft.Extensions.Hosting.Functional.Testsopt in.UnsafeMigrationFixAllProvidermerges each fix as one minimal edit (a conflict used to silently drop every fix in a file), andUnsafeContextPlannergets the block-first ordering from Enroll System.IO.Compression and its tests in unsafe-v2 #136657 without its test updates. Drop that commit once Enroll System.IO.Compression and its tests in unsafe-v2 #136657 lands.Enrolled assemblies (43)
Related: #131451 (tracking), #136664 (enrollment tracking), #136621 (infrastructure), #136657 (System.IO.Compression).
Blocked by #136657 (has to be merged first).