Skip to content

Add a conditional regression test for high-speed NetworkInterface.Speed - #136354

Closed
springmin wants to merge 1 commit into
dotnet:mainfrom
springmin:pr/ohos-nic-speed-test
Closed

springmin wants to merge 1 commit into
dotnet:mainfrom
springmin:pr/ohos-nic-speed-test

Conversation

@springmin

Copy link
Copy Markdown
Contributor

Summary

Adds a conditional regression test for the Android/OpenHarmony ethtool speed truncation fixed in #136194.

NetworkInterface.Speed is compared with /sys/class/net/<iface>/speed only when the kernel reports more than 65535 Mbps; interfaces where sysfs is unavailable or the PAL reports Speed <= 0 are skipped.

This is hardware-only coverage: the bug needs a NIC above 65535 Mbps, and CI machines do not have one. A deterministic native harness is tracked in #136353.

Merge after #136194.

Note

This PR was drafted with AI assistance (agent tooling) under the author's direction.

The Android/OpenHarmony ethtool path can truncate speeds above 65535 Mbps.
Compare NetworkInterface.Speed with /sys/class/net/<iface>/speed when the
kernel reports a high-speed link; skip interfaces where sysfs is unavailable.
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Oct 23, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @karelz, @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@springmin

Copy link
Copy Markdown
Contributor Author

@dotnet/ncl could someone take a look at this regression test when you have a moment? It is the follow-up to #136194; CI is green (74 pass, 0 fail). The test only asserts when /sys/class/net/<iface>/speed reports more than 65535 Mbps, so it skips on current CI machines; the deterministic native harness is tracked in #136353.

Note

This comment was drafted with AI assistance (agent tooling) under the author's direction.

@rzikm

rzikm commented Oct 26, 2026

Copy link
Copy Markdown
Member

We usually add the regression test in the same PR that lands the fix, having now 2 PRs and one issue makes things messy and chaotic to understand what is going on

@springmin

Copy link
Copy Markdown
Contributor Author

Moved the regression test into #136194 (6364648b5a4) per review, so the fix and its regression test land together. Closing this separate PR.

Note

This comment was drafted with AI assistance (agent tooling) under the author's direction.

@springmin springmin closed this Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.Net community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants