Skip to content

Arm64-SVE: Support Vector<T> as element of an array - #133943

Open
snickolls-arm wants to merge 7 commits into
dotnet:mainfrom
snickolls-arm:vectort-in-array
Open

Arm64-SVE: Support Vector<T> as element of an array#133943
snickolls-arm wants to merge 7 commits into
dotnet:mainfrom
snickolls-arm:vectort-in-array

Conversation

@snickolls-arm

@snickolls-arm snickolls-arm commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Convert GenTreeIndexAddr::gtElemSize from unsigned to ValueSize to allow reasoning on a runtime evaluated size.

When indexing Vector<T>[], scale the index by Sve.Count8BitElements at runtime before accessing.

@snickolls-arm
Arm64-SVE: Support Vector<T> as element of an array
c2ffcc2 
Convert GenTreeIndexAddr::gtElemSize from `unsigned` to `ValueSize` to allow
reasoning on a runtime evaluated size.

When indexing `Vector<T>[]`, scale the index by `Sve.Count8BitElements` at runtime
before accessing.
@github-actions github-actions Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 15, 2026
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Sep 15, 2026
@azure-pipelines

azure-pipelines Bot commented Sep 15, 2026

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 8 pipeline(s).
8 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

dotnet-policy-service Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

This was referenced Sep 15, 2026
Open
Open
Closed
@snickolls-arm snickolls-arm mentioned this pull request Sep 23, 2026
Open
4 of 18 tasks
@SwapnilGaikwad

SwapnilGaikwad commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

cc: @dotnet/arm64-contrib @SwapnilGaikwad @dhartglassMSFT

jakobbotsch
jakobbotsch reviewed Sep 30, 2026
View reviewed changes
Comment thread src/coreclr/jit/morph.cpp Resolved
@build-analysis build-analysis Bot mentioned this pull request Oct 6, 2026
Open
@build-analysis build-analysis Bot mentioned this pull request Oct 7, 2026
Closed
@snickolls-arm

snickolls-arm commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

The failures on x64 superpmi seem consistent, I will need to look into these. It's failing at codegen in ins_Copy.

@JulieLeeMSFT

JulieLeeMSFT commented Oct 8, 2026

Copy link
Copy Markdown
Member

@dhartglassMSFT PTAL.

@snickolls-arm

snickolls-arm commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

The failures on x64 superpmi seem consistent, I will need to look into these. It's failing at codegen in ins_Copy.

These seem to have been fixed by #135327

dhartglassMSFT
dhartglassMSFT reviewed Oct 14, 2026
View reviewed changes
Comment thread src/coreclr/jit/lsraarm64.cpp Resolved
dhartglassMSFT
dhartglassMSFT reviewed Oct 14, 2026
View reviewed changes
Comment thread src/coreclr/jit/gentree.cpp Resolved
dhartglassMSFT
dhartglassMSFT reviewed Oct 15, 2026
View reviewed changes
Comment thread src/coreclr/jit/gentree.cpp Resolved
@snickolls-arm
Review comments
5edae94 
* Fix ValueSize hashing
* Assert zero constant index offsets
* Fix missing zero extension for MADD
This was referenced Oct 15, 2026
Closed
Closed
@jkotas jkotas added the arm-sve Work related to arm64 SVE/SVE2 support label Oct 16, 2026
@SwapnilGaikwad SwapnilGaikwad mentioned this pull request Oct 26, 2026
Open
27 tasks
@snickolls-arm

snickolls-arm commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

The replay failure seems to be coming from tests/JIT/Regression/JitBlue/Runtime_135509, with JitStressRegs=3. Possibly some more change needed for #135509.

@dhartglassMSFT Is this OK to merge?

@SwapnilGaikwad

SwapnilGaikwad commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

The replay failure seems to be coming from tests/JIT/Regression/JitBlue/Runtime_135509, with JitStressRegs=3. Possibly some more change needed for #135509.

@dhartglassMSFT Is this OK to merge?

#136642 shall address the JIT stress failure.

@dhartglassMSFT
dhartglassMSFT enabled auto-merge (squash) November 1, 2026 22:25

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakobbotsch jakobbotsch jakobbotsch left review comments
@dhartglassMSFT dhartglassMSFT dhartglassMSFT left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@snickolls-arm @SwapnilGaikwad @JulieLeeMSFT @jakobbotsch @dhartglassMSFT @jkotas