Repository navigation
Use writable UserSecrets path on Apple mobile - #133165
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration |
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This was referenced Sep 3, 2026
svick
marked this pull request as ready for review
September 4, 2026 11:32
svick
requested review from
mrek-msft and
rosebyte
and
a lite review from Copilot
September 4, 2026 11:32
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The behavior change is narrowly scoped to Apple mobile targets, addresses a concrete writability issue, and includes test re-enablement consistent with the updated path resolution.
Pull request overview
Updates UserSecrets path resolution on Apple mobile targets to avoid using an unwritable HOME-based location, and re-enables previously skipped UserSecrets tests on iOS/tvOS now that the path should be writable.
Changes:
- Ignore
HOMEwhen resolving the secrets root on iOS/tvOS/MacCatalyst so resolution falls back to a writable special folder path. - Update
PathHelperTestexpected-path logic to account for the Apple mobile fallback behavior. - Remove
ActiveIssueskips to re-enable UserSecrets tests on iOS/tvOS.
File summaries
| File | Description |
|---|---|
| src/libraries/Microsoft.Extensions.Configuration.UserSecrets/src/PathHelper.cs | Treat HOME as unusable on iOS/tvOS/MacCatalyst so secrets resolve under a writable folder (via SpecialFolder.ApplicationData). |
| src/libraries/Microsoft.Extensions.Configuration.UserSecrets/tests/PathHelperTest.cs | Adjust expected-path computation to match the Apple mobile secrets-root fallback behavior. |
| src/libraries/Microsoft.Extensions.Configuration.UserSecrets/tests/ConfigurationExtensionTest.cs | Re-enable iOS/tvOS coverage by removing ActiveIssue skips for UserSecrets extension tests. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
rosebyte
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #132074
Fixes #60584
Summary
HOMEdirectory when resolving the UserSecrets path on iOS, tvOS, and MacCatalystTesting
dotnet build src\libraries\Microsoft.Extensions.Configuration.UserSecrets\src\Microsoft.Extensions.Configuration.UserSecrets.csprojdotnet build /t:test src\libraries\Microsoft.Extensions.Configuration.UserSecrets\tests\Microsoft.Extensions.Configuration.UserSecrets.Tests.csprojdotnet build /t:test src\libraries\Microsoft.Extensions.Configuration\tests\FunctionalTests\Microsoft.Extensions.Configuration.Functional.Tests.csprojNote
This pull request description was drafted with GitHub Copilot.