Explain why RSA PKCS1 implicit rejection isn't used - #126887
Merged
PranavSenthilnathan merged 2 commits intoJul 7, 2026
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security |
Contributor
There was a problem hiding this comment.
Pull request overview
Expands the in-source documentation in the OpenSSL RSA interop layer to explain why .NET disables OpenSSL’s PKCS#1 RSA “implicit rejection” behavior (and attempts to turn it off via rsa_pkcs1_implicit_rejection).
Changes:
- Replaces the existing brief explanation with a more detailed comment describing OpenSSL’s implicit rejection behavior and the motivation for disabling it.
- Adds additional rationale bullets covering compatibility/spec alignment and security considerations.
PranavSenthilnathan
changed the title
This was referenced Apr 14, 2026
bartonjs
approved these changes
Apr 15, 2026
PranavSenthilnathan
enabled auto-merge (squash)
July 7, 2026 03:43
eiriktsarpalis
pushed a commit
that referenced
this pull request
Jul 15, 2026
Expands comments on why we don't use implicit rejection for RSA PKCS#1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expands comments on why we don't use implicit rejection for RSA PKCS#1.