Repository navigation
[HTTP] Fix test race with semaphore. - #124388
Merged
ManickaP merged 1 commit intoFeb 16, 2026
Merged
Conversation
Member
Author
|
/azp list |
Member
Author
|
/azp run runtime-libraries-coreclr outerloop |
ManickaP
marked this pull request as ready for review
February 13, 2026 15:31
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a race condition in the Send_TimeoutRequestContent_Throws test where the server connection could close before the client properly timed out, causing the test to fail intermittently with an HttpRequestException instead of the expected TaskCanceledException with TimeoutException inner exception.
Changes:
- Removed the
[ActiveIssue]attribute that was tracking the flaky test - Added semaphore-based synchronization between client and server to ensure the server stays alive until the client completes its assertions
MihaZupan
approved these changes
Feb 13, 2026
This was referenced Feb 13, 2026
Open
Member
Author
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/ba-g unrelated infra, outerloop Http tetsts are passing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39056