Skip to content

Fix meter/instrument filtering in MetricsEventSource - #107267

Merged
tarekgh merged 2 commits into
dotnet:mainfrom
tarekgh:FixFilteringInMetricsEventSource
Sep 4, 2024
Merged

tarekgh merged 2 commits into
dotnet:mainfrom
tarekgh:FixFilteringInMetricsEventSource

Conversation

@tarekgh

@tarekgh tarekgh commented Sep 2, 2024

Copy link
Copy Markdown
Member

No description provided.

@tarekgh tarekgh added this to the 9.0.0 milestone Sep 2, 2024
@tarekgh
tarekgh requested a review from noahfalk September 2, 2024 22:05
@tarekgh

tarekgh commented Sep 2, 2024

Copy link
Copy Markdown
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@tarekgh

tarekgh commented Sep 3, 2024

Copy link
Copy Markdown
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@noahfalk noahfalk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tarekgh
tarekgh merged commit 97f92a3 into dotnet:main Sep 4, 2024
@tarekgh

tarekgh commented Sep 4, 2024

Copy link
Copy Markdown
Member Author

/backport to release/9.0

@github-actions

github-actions Bot commented Sep 4, 2024

Copy link
Copy Markdown
Contributor

Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10709323402

radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Sep 6, 2024
* Fix meter/instrument filtering in MetricsEventSource

* Address the feedback
@sebastienros

Copy link
Copy Markdown
Member

I confirm this is fixing the regressions with HttpClient instances. I am not seeing "msquic" events anymore after it either.

@tarekgh

tarekgh commented Sep 6, 2024

Copy link
Copy Markdown
Member Author

Thanks @sebastienros for confirming!

jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Sep 17, 2024
* Fix meter/instrument filtering in MetricsEventSource

* Address the feedback
sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
* Fix meter/instrument filtering in MetricsEventSource

* Address the feedback
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants