Repository navigation
[WASI] finalizer + HTTP client child resources - #107096
Merged
pavelsavara merged 5 commits intoAug 29, 2024
Merged
Conversation
- rewrite HTTP to respect child resources
pavelsavara
added
arch-wasm
pavelsavara
commented
Aug 28, 2024
| #if defined(HOST_WASI) | ||
| // TODO: Schedule the background job on WASI. Threads aren't yet supported in this build. | ||
| #if defined(HOST_WASI) && defined(DISABLE_THREADS) | ||
| mono_runtime_do_background_work (); |
Member
Author
There was a problem hiding this comment.
I'm not confident what are problems of doing it here synchronously and inline, for single-threaded runtime. Will test and see what happens.
pavelsavara
commented
Aug 28, 2024
pavelsavara
added a commit
to pavelsavara/runtimelab
that referenced
this pull request
Aug 28, 2024
dicej
reviewed
Aug 28, 2024
dicej
left a comment
dicej
left a comment
Contributor
There was a problem hiding this comment.
LGTM overall. Thanks for doing this!
Just a few comments and questions inline.
Member
Author
|
I expect this is still early version of the code. Until we have better test coverage, with our existing test suite.
|
This was referenced Aug 29, 2024
dicej
pushed a commit
to dicej/runtimelab
that referenced
this pull request
Aug 29, 2024
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
Co-authored-by: Joel Dice <joel.dice@fermyon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related bytecodealliance/wit-bindgen#1039