Skip to content

Remove HelperMethodFrame from GetMulticastInvoke - #105584

Merged
AaronRobinsonMSFT merged 3 commits into
dotnet:mainfrom
AaronRobinsonMSFT:hmf_delegates
Jul 27, 2024
Merged

AaronRobinsonMSFT merged 3 commits into
dotnet:mainfrom
AaronRobinsonMSFT:hmf_delegates

Conversation

@AaronRobinsonMSFT

@AaronRobinsonMSFT AaronRobinsonMSFT commented Jul 27, 2024 •

Copy link
Copy Markdown
Member

Move MethodTable acquisition from unmanaged to managed.
This allows for converting instance FCalls to static.

Move MethodTable acquisition from unmanaged to managed.
This allows for converting instance FCalls to static.
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Comment thread src/coreclr/System.Private.CoreLib/src/System/Delegate.CoreCLR.cs Outdated
Comment thread src/coreclr/System.Private.CoreLib/src/System/Delegate.CoreCLR.cs Outdated
@AaronRobinsonMSFT
AaronRobinsonMSFT marked this pull request as ready for review July 27, 2024 15:03

@jkotas jkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkotas

jkotas commented Jul 27, 2024

Copy link
Copy Markdown
Member

I see ~8% improvement in a delegate combine microbenchmark.

@AaronRobinsonMSFT
AaronRobinsonMSFT merged commit 3471de7 into dotnet:main Jul 27, 2024
@AaronRobinsonMSFT
AaronRobinsonMSFT deleted the hmf_delegates branch July 27, 2024 20:24
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants