Skip to content

Fix issue link for an expected difference in warning behavior - #104760

Merged
sbomer merged 2 commits into
dotnet:mainfrom
sbomer:fixIssueLink
Jul 12, 2024
Merged

sbomer merged 2 commits into
dotnet:mainfrom
sbomer:fixIssueLink

Conversation

@sbomer

@sbomer sbomer commented Jul 11, 2024 •

Copy link
Copy Markdown
Member

These warnings are intentionally only produced by Native AOT. Analyzer doesn't detect reflection access to Requires* attributes other than RequiresUnreferencedCode, per discussion in dotnet/linker#2739. Replacing the issue links so we can close that issue.

Fixes dotnet/linker#2739

sbomer added 2 commits July 11, 2024 21:34
These warnings are intentionally only produced by Native AOT. Analyzer doesn't detect
reflection access to Requires* attributes other than RequiresUnreferencedCode.
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 11, 2024
@dotnet-policy-service dotnet-policy-service Bot added the linkable-framework Issues associated with delivering a linker friendly framework label Jul 11, 2024
@sbomer
sbomer marked this pull request as ready for review July 12, 2024 15:21
@sbomer
sbomer requested a review from marek-safar as a code owner July 12, 2024 15:21

@vitek-karas vitek-karas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@github-actions github-actions Bot locked and limited conversation to collaborators Aug 12, 2024
@sbomer
sbomer deleted the fixIssueLink branch June 26, 2026 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

linkable-framework Issues associated with delivering a linker friendly framework needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DAM interaction with RequiresAttribute

3 participants