You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[wasm] AOT: System.Numerics.Tensors.Tests - aot-instances.dll with exit code 137 #96631
But that's just fixing a minor issue from #94555 (7e51126) and isn't doing anything really unique here, it's just taking an already generic method and dispatching to one of two concrete implementations based on the type of T
This is probably an OOM. It started with 7e51126, which seems to have a caused the aot compiler to generate way more generic instances. Will investigate.
Possibly the same issue as #96630 then. I had initially thought the OOM might be due to the new static virtuals + generics methods, but hitting that even after breaking it apart to 8 concrete APIs.
Activity
radical commentedon Jan 8, 2024
This started being hit with db90a849 (build). The last passing build was 7957edc2 (build).
The diff should be within 7957edc...db90a84 .
radical commentedon Jan 8, 2024
cc @tannergooding @vargaz
tannergooding commentedon Jan 8, 2024
I'd presume that it's https://github.com/dotnet/runtime/tree/d3be0ecf5a384189acd82f6c5b2631c1db423873
But that's just fixing a minor issue from #94555 (7e51126) and isn't doing anything really unique here, it's just taking an already generic method and dispatching to one of two concrete implementations based on the type of
Tvargaz commentedon Jan 8, 2024
This is probably an OOM. It started with 7e51126, which seems to have a caused the aot compiler to generate way more generic instances. Will investigate.
tannergooding commentedon Jan 8, 2024
Possibly the same issue as #96630 then. I had initially thought the OOM might be due to the new
static virtuals+genericsmethods, but hitting that even after breaking it apart to 8 concrete APIs.vargaz commentedon Jan 8, 2024
It looks like the failure is actually caused by the generic classes added to the test suite i.e. TensorPrimitives.Generic.cs.
vargaz commentedon Jan 8, 2024
Compiling this test suite with
<WasmDedup>false</WasmDedup>will probably work around the failure.tannergooding commentedon Jan 8, 2024
Which property needs to be set to
false?vargaz commentedon Jan 9, 2024
<WasmDedup>false</WasmDedup>tannergooding commentedon Jan 9, 2024
Do you expect #96630 is the same issue?
That one appears to be getting hit for
System.Private.Corelibso it may not be as easy or as desirable to use that property there?tannergooding commentedon Jan 10, 2024
Keeping this open so that the underlying issue with LLVM can be tracked/resolved.
vargaz commentedon Jan 10, 2024
Its tracked here:
#95791
radical commentedon Jan 11, 2024
this is still being hit for
System.Numerics.Tensors.Net8.Testswhich needsWasmDedup=falsealso.log.
And the failure on
System.Numerics.Tensors.Testsis for the test assembly now instead ofaot-instances.dll(log:radical commentedon Jan 11, 2024
I'll open two separate issues.