Repository navigation
[iOS][non-icu] HybridGlobalization rafactor condition checks / clean up the code #96328
Description
- Define APPLE_HYBRID_GLOBALIZATION symbol for the 3 OSes and use it throughout the implementation instead of defined(TARGET_MACCATALYST) || defined(TARGET_IOS) || defined(TARGET_TVOS) conditions in all files under
https://github.com/dotnet/runtime/tree/main/src/native/libs/System.Globalization.Native -
HybridGlobalizationis supported only on iOS/tvOS/macCatalyst not OSX. RenameIsHybridGlobalizationOnOSX/IsNotHybridGlobalizationOnOSXtoIsHybridGlobalizationOnApplePlatform/IsNotHybridGlobalizationOnApplePlatformhttps://github.com/dotnet/runtime/blob/main/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs#L384. - Remove
IsIcuGlobalizationAndNotHybridproperty -
Check if possible to include"pal_utilities.h"inpal_placeholders.hinstead of defining asserts, look discussion [HybridGlobalization] Include all globalization symbols #96684 (comment)
we shouldn't mix our configs with pal_config.h.in, so we will keep the way it was implemented.
Contributes to #80689
Activity
jkotas commentedon Dec 27, 2023
This should be IsHybridGlobalizationOnApplePlatform. It returns true on more OSes, not just iOS. The name does not need to encode the fact that the hybrid globalization is not available in macOS build currently.
[-][iOS][non-icu] HybridGlobalization rafactor condition checks[/-][+][iOS][non-icu] HybridGlobalization rafactor condition checks / clean up the code[/+]