DisabledRuntimeMarshalling.PInvokeAssemblyMarshallingEnabled.DelegatesFromExternalAssembly.StructWithDefaultNonBlittableFields() failing #94931

Activity

1. lewing

   added

   blocking-clean-ciBlocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'

   Known Build ErrorUse this to report build issues in the .NET Helix tabUse this to report build issues in the .NET Helix tab

   on Nov 17, 2023
2. ghost added

   needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area ownersAn area label is needed to ensure this gets routed to the appropriate area owners

   on Nov 17, 2023
3. ghost added

   untriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner

   on Nov 17, 2023
4. lewing commented on Nov 17, 2023

   

   lewing

   on Nov 17, 2023

   MemberAuthor

   More actions

   Seen in #94878 which is a revert of a recent commit.
5. jkotas

   added

   area-Interop-coreclr

   and removed

   needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area ownersAn area label is needed to ensure this gets routed to the appropriate area owners

   on Nov 17, 2023
6. AndyAyersMS commented on Nov 17, 2023

   

   AndyAyersMS

   on Nov 17, 2023

   Member

   More actions

   Looks like #94900 is a dup.
7. AaronRobinsonMSFT commented on Nov 17, 2023

   

   AaronRobinsonMSFT

   on Nov 17, 2023

   Member

   More actions

   This repos without issue. I've no idea how this passed CI.
8. AaronRobinsonMSFT commented on Nov 17, 2023

   

   AaronRobinsonMSFT

   on Nov 17, 2023

   Member

   More actions

   The native code is returning false, but for some reason it is being converted to a true.

   runtime/src/tests/Interop/DisabledRuntimeMarshalling/DisabledRuntimeMarshallingNative.cpp

   Lines 27 to 30 in b88c74a

   	extern "C" DLL_EXPORT bool STDMETHODCALLTYPE CheckStructWithShortAndBool(StructWithShortAndBool str, short s, bool b)
   	{
   	return str.s == s && str.b == b;
   	}

   runtime/src/tests/Interop/DisabledRuntimeMarshalling/PInvokeAssemblyMarshallingEnabled/Delegates.cs

   Lines 13 to 22 in b88c74a

   	[Fact]
   	public static void StructWithDefaultNonBlittableFields()
   	{
   	short s = 42;
   	bool b = true;
   	var callback = Marshal.GetDelegateForFunctionPointer<CheckStructWithShortAndBoolCallback>((IntPtr)DisabledRuntimeMarshallingNative.GetStructWithShortAndBoolCallback());
   	Assert.False(callback(new StructWithShortAndBool(s, b), s, b));
   	}
9. AaronRobinsonMSFT commented on Nov 17, 2023

   

   AaronRobinsonMSFT

   on Nov 17, 2023

   Member

   More actions

   This looks like a recent C++ tool chain update that has uncovered a test bug. Will have a fix up shortly.
10. AndyAyersMS commented on Nov 17, 2023

    

    AndyAyersMS

    on Nov 17, 2023

    Member

    More actions

    I noticed the C++ compilers had been updated but didn't connect the dots. Thanks for getting to the bottom of this one.
11. ghost added

    in-prThere is an active PR which will close this issue when it is mergedThere is an active PR which will close this issue when it is merged

    on Nov 18, 2023
12. AaronRobinsonMSFT

    removed

    untriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner

    on Nov 18, 2023
13. AaronRobinsonMSFT

    added this to the 9.0.0 milestone on Nov 18, 2023
14. AaronRobinsonMSFT

    self-assigned this

    on Nov 18, 2023
15. jkotas

    closed this as completedin #94942on Nov 20, 2023
16. ghost removed

    in-prThere is an active PR which will close this issue when it is mergedThere is an active PR which will close this issue when it is merged

    on Nov 20, 2023
17. github-actions

    locked and limited conversation to collaborators on Dec 20, 2023