Skip to content

Regressions in System.Net.Tests.Perf_WebUtility on arm64 #84787

Closed

Description

@performanceautofiler

Run Information

Name Value
Architecture arm64
OS ubuntu 20.04
Queue AmpereUbuntu
Baseline 7b651743dc951384f6c3d8455c88518022c7c3b9
Compare b0b7aaefb88aa8d01b3d64fb40ac2f73a9d98c3e
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Net.Tests.Perf_WebUtility

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Decode_NoDecodingRequired - Duration of single invocation 80.17 ns 87.66 ns 1.09 0.09 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

Payloads

Baseline
Compare

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Net.Tests.Perf_WebUtility*'
Details

Payloads

Baseline
Compare

Histogram

System.Net.Tests.Perf_WebUtility.Decode_NoDecodingRequired


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 87.65567056152061 > 84.72435361342947.
IsChangePoint: Marked as a change because one of 3/21/2023 2:53:21 PM, 3/23/2023 3:52:33 AM falls between 3/14/2023 3:18:57 PM and 3/23/2023 3:52:33 AM.
IsRegressionStdDev: Marked as regression because -17.95135109670125 (T) = (0 -88.01258049891231) / Math.Sqrt((2.5000512794458047 / (33)) + (0.2977841763370414 / (4))) is less than -2.0301079282477414 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (33) + (4) - 2, .025) and -0.08583376758709343 = (81.05529881842888 - 88.01258049891231) / 81.05529881842888 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Run Information

Name Value
Architecture arm64
OS ubuntu 20.04
Queue AmpereUbuntu
Baseline 7b651743dc951384f6c3d8455c88518022c7c3b9
Compare b0b7aaefb88aa8d01b3d64fb40ac2f73a9d98c3e
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Activity

  1. removed
    untriagedNew issue has not been triaged by the area owner
    on Apr 1, 2023
  2. AndyAyersMS commented on Apr 1, 2023

    @AndyAyersMS
    Member

    Regression in System.Net.Tests.Perf_WebUtility has persisted. However given its history we should wait a bit longer.

    Implicated changes:

  3. AndyAyersMS commented on Apr 13, 2023

    @AndyAyersMS
    Member

    newplot - 2023-04-13T093635 894

    Still looks like a real regression. Will transfer this one.

  4. ghost added
    needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners
    on Apr 13, 2023
  5. ghost added
    untriagedNew issue has not been triaged by the area owner
    on Apr 13, 2023
  6. changed the title [-][Perf] Linux/arm64: 2 Regressions on 3/21/2023 8:47:40 PM[/-] [+]Regressions in System.Net.Tests.Perf_WebUtility on arm64[/+] on Apr 13, 2023
  7. added
    area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
    and removed
    untriagedNew issue has not been triaged by the area owner
    needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners
    on Apr 13, 2023
  8. added this to the 8.0.0 milestone on Apr 13, 2023
  9. AndyAyersMS commented on Jun 1, 2023

    @AndyAyersMS
    Member

    Fixed by enabling Dynamic PGO

    newplot - 2023-06-01T154310 650

  10. ghost locked as resolved and limited conversation to collaborators on Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

arch-arm64area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIos-linuxLinux OS (any supported distro)runtime-coreclrspecific to the CoreCLR runtime

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions