Consider passing enregisterLocalVars as a template argument to LinearScan

Today, we check for enregisterLocalVars at lot of hot code in LinearScan and probably templatizing it would be better.

Evaluate the impact on binary size if we do it. If it increases the size significantly, extract out the checks for enregisterLocalVars out of some of the loops or add special paths for it.
Evaluate what is the TP gain with it.

@kunalspathak

@kunalspathak is this going to be .NET 8 work?

Most likely. Let us keep it in .NET 8 for now and we can reevaluate in next month or so.

Here is the list of methods that has the checks for if(enregisterLocalVars)

recordVarLocationsAtStartOfBB : Called from codegen that cannot access private enregisterLocalVars.
isRegCandidate <-- no change in size
identifyCandidates <-- no change in size
loop and much of the code inside identifyCandidates <-- no change in size
initVarRegMap <-- no change in size
processBlockEndAllocation <-- no change in size
processBlockStartLocations <-- no change in size
much of the code in resolveRegisters() <-- 1KB increase
isContainableMemoryOp : Not worth doing.
buildKillPositionsForNode : Not worth doing.
buildIntervals <-- 3KB size increase. Will re-evaluate.

Navigation Menu