Repository navigation
Add CollectionsMarshal support for the HashSet<T> collection #82840
Description
Background and motivation
The Dictionary<TKey,TValue> collection was improved in .NET 6, by introducing direct ref access to its values. This improvement made the collection more suitable for performance-critical applications, by reducing the number of times a key has to be hashed when adding/modifying values in the collection. For example the GetOrAdd extension method can be implemented efficiently with a single hashing of the key. The same improvement could be made to the HashSet<T> collection as well. A GetOrAdd API has also been proposed for the HashSet<T>, but that proposal was closed with a mention about adding CollectionsMarshal support in the future. This proposal here is exactly about adding this support.
API Proposal
namespace System.Runtime.InteropServices
{
public static partial class CollectionsMarshal
{
public static ref T? GetValueRefOrAddDefault<T> (HashSet<T> hashSet, T item, out bool exists);
public static ref T GetValueRefOrNullRef<T> (HashSet<T> hashSet, T item);
}
}API Usage
Below is a partial implementation of a concurrent HashSet<T> with bounded capacity. The proposed API GetValueRefOrAddDefault is used when space is available in the collection, and the proposed API GetValueRefOrNullRef is used when the collection is full:
public partial class ConcurrentBoundedHashSet<T>
{
private readonly HashSet<T> _set = new();
private readonly int _boundedCapacity;
/// <summary>
/// Searches the set for a given value and returns the equal value it finds,
/// otherwise adds the given value to the set if space is available,
/// otherwise returns false.
/// </summary>
public bool TryGetOrAdd(T equalValue, out T? actualValue)
{
lock (_set)
{
if (_set.Count < _boundedCapacity)
{
ref T? valueRef = ref CollectionsMarshal.GetValueRefOrAddDefault(_set, equalValue,
out bool exists);
if (!exists) valueRef = equalValue;
actualValue = valueRef; return true;
}
else
{
ref T valueRef = ref CollectionsMarshal.GetValueRefOrNullRef(_set, equalValue);
if (!Unsafe.IsNullRef(ref valueRef))
{
actualValue = valueRef; return true;
}
else
{
actualValue = default; return false;
}
}
}
}
}Alternative Designs
No response
Risks
None that I can think of.
Labels: area-System.Collections / api-suggestion.
Activity
eiriktsarpalis commentedon Mar 1, 2023
The CollectionMarshal methods for Dictionary provide
refaccess to the value of a given entry, not its key. In the case of HashSet you'd be necessarily permitting external modification of the key itself which has a number of problems:AddDefaultmean inGetValueRefOrAddDefault? If you're actually addingdefault(T)then that would not be equal to theitemparameter and for reference types it would benullwhich is not a supported key value.refwould corrupt the hashtable unless the value you're setting it with is equal to the original value.stephentoub commentedon Mar 1, 2023
I agree with @eiriktsarpalis; the proposed
GetValueRefOrAddDefaultdoesn't seem viable. I could see us addingGetValueRefOrNullRefif it were changed to return aref readonly, but I don't know what scenarios that would really aid (presumably the same ones that wanted the overload that returns the actual value, and those are relatively rare, then here compounding that rarity by also wanting it by ref).theodorzoulias commentedon Mar 1, 2023
@eiriktsarpalis, @stephentoub you are both right. This was a poorly thought proposal.
On top of the above, in the "API Usage" example the
elseblock can be trivially replaced withreturn _set.TryGetValue(equalValue, out actualValue);.I am closing this one.