Skip to content

Consider improving the source formatter in the STJ source generator #81260

New issue
New issue
Closed
Closed
Consider improving the source formatter in the STJ source generator#81260
Labels
area-System.Text.JsonenhancementProduct code improvement that does NOT require public API changes/additionssource-generatorIndicates an issue with a source generator feature
Milestone
Future

Description

@eiriktsarpalis
eiriktsarpalis
opened on Jan 27, 2023
          FWIW, we use IndentedTextWriter for this purpose in the regex generator.

Originally posted by @stephentoub in #81239 (comment)

          This use of literals spanning newlines is going to build the newline of whatever platform this is compiled on into the source generator, so e.g. if the source generator is built on Windows, then when it's used on Linux it's going to emit \r\n for newlines.  Do we normalize that somewhere?

Originally posted by @stephentoub in #81239 (comment)

Activity

  1. ghost added
    area-System.Text.RegularExpressions
    on Jan 27, 2023
  2. ghost added
    untriagedNew issue has not been triaged by the area owner
    on Jan 27, 2023
  4. eiriktsarpalis
    added
    enhancementProduct code improvement that does NOT require public API changes/additions
    area-System.Text.Json
    and removed
    untriagedNew issue has not been triaged by the area owner
    enhancementProduct code improvement that does NOT require public API changes/additions
    area-System.Text.RegularExpressions
    on Jan 27, 2023
  6. eiriktsarpalis
    added
    enhancementProduct code improvement that does NOT require public API changes/additions
    source-generatorIndicates an issue with a source generator feature
    on Jan 27, 2023
  7. eiriktsarpalis
    added this to the 8.0.0 milestone on Jan 27, 2023
  8. krwq
    modified the milestones: 8.0.0, Future on Jan 30, 2023

  9. eiriktsarpalis commented on Jun 7, 2023

    @eiriktsarpalis
    eiriktsarpalis
    on Jun 7, 2023
    MemberAuthor

    Fixed by #86526

  10. eiriktsarpalis
    closed this as completedon Jun 7, 2023
  11. ghost locked as resolved and limited conversation to collaborators on Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-System.Text.JsonenhancementProduct code improvement that does NOT require public API changes/additionssource-generatorIndicates an issue with a source generator feature

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions