You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
changed the title [-][Test failure] NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds[/-][+][Test failure] System.Net.Http.Functional.Tests.PlatformHandler_HttpClientHandler_ServerCertificates_Test.NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds[/+]on Nov 1, 2022
System.Net.Http.Functional.Tests.PlatformHandler_HttpClientHandler_ServerCertificates_Test.NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds [FAIL]
System.Net.Http.HttpRequestException : An error occurred while sending the request.
---- System.Net.Http.WinHttpException : Error 12175 calling WINHTTP_CALLBACK_STATUS_REQUEST_ERROR, 'A security error occurred'.
Stack Trace:
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
/_/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.ServerCertificates.cs(234,0): at System.Net.Http.Functional.Tests.HttpClientHandler_ServerCertificates_Test.<NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds>d__19.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
----- Inner Stack Trace -----
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
/_/src/libraries/Common/src/System/Threading/Tasks/RendezvousAwaitable.cs(64,0): at System.Threading.Tasks.RendezvousAwaitable`1.GetResult()
/_/src/libraries/System.Net.Http.WinHttpHandler/src/System/Net/Http/WinHttpHandler.cs(946,0): at System.Net.Http.WinHttpHandler.<StartRequestAsync>d__122.MoveNext()
Docs for 12175 ERROR_WINHTTP_SECURE_FAILURE: One or more errors were found in the Secure Sockets Layer (SSL) certificate sent by the server. To determine what type of error was encountered, check for a WINHTTP_CALLBACK_STATUS_SECURE_FAILURE notification in a status callback function. For more information, see WINHTTP_STATUS_CALLBACK.
Seems like cert problem, can it be expired? And if I get the description right, does it mean there are more details about the error available? If so, would it be worthwhile to retrieve them?
cc @wfurt@rzikm
The test is using https://revoked.badssl.com/ and it expired 10/27. Since this is outer loop test we may ignore it for few more days. The badssl.com usually fix their certs eventually.
It is still shown as revoked so we may alternatively fix the validation tests to ignore expiration and only check revocation.
But I'm not sure if it is worth of the troubles.
Last option IMHO is to remove dependency on badssl.com and host our own sites.
Activity
[-][Test failure] NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds[/-][+][Test failure] System.Net.Http.Functional.Tests.PlatformHandler_HttpClientHandler_ServerCertificates_Test.NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds[/+]ManickaP commentedon Nov 1, 2022
Based on the console log, the error is this:
Docs for 12175
ERROR_WINHTTP_SECURE_FAILURE: One or more errors were found in the Secure Sockets Layer (SSL) certificate sent by the server. To determine what type of error was encountered, check for a WINHTTP_CALLBACK_STATUS_SECURE_FAILURE notification in a status callback function. For more information, see WINHTTP_STATUS_CALLBACK.Seems like cert problem, can it be expired? And if I get the description right, does it mean there are more details about the error available? If so, would it be worthwhile to retrieve them?
cc @wfurt @rzikm
wfurt commentedon Nov 1, 2022
We should try to reproduce it. If it is expired certificate it will show up consistently.
ManickaP commentedon Nov 1, 2022
Triage: needs to be tested locally if it's a cert problem (should be easily reproducible). If so, we should promptly fix this or disable the test.
wfurt commentedon Nov 1, 2022
The test is using https://revoked.badssl.com/ and it expired 10/27. Since this is outer loop test we may ignore it for few more days. The
badssl.comusually fix their certs eventually.It is still shown as revoked so we may alternatively fix the validation tests to ignore expiration and only check revocation.
But I'm not sure if it is worth of the troubles.
Last option IMHO is to remove dependency on
badssl.comand host our own sites.wfurt commentedon Nov 1, 2022
BTW this is easy to reproduce and
SocketsHttpHandlerfails as wellrzikm commentedon Nov 2, 2022
badssl issue: chromium/badssl.com#515
8 remaining items
rzikm commentedon Jan 4, 2024
We should also disable the tests in 7.0 and 6.0 to clean up CI there.
karelz commentedon Jun 24, 2024
Tests were disabled in main (8.0) in PR #79407 and in 7.0.x in PR #96053 and in 6.0.x in PR #96055