Repository navigation
The browser-wasm SDK should automatically reference the threading/perf-tracing ref assemblies #72872
Description
Some property property that uses the multithreaded runtime pack for the runtime artifacts and that adds a <PackageReference Include="Microsoft.NET.WebAssembly.Threading" IncludeAssets="compile" PrivateAssets="none" /> package to use the right ref assemblies.
And the same thing for the perftrace runtime pack and the System.Diagnostics.Tracing.WebAssembly.PerfTracing ref assemblies
Activity
lambdageek commentedon Jul 26, 2022
I think this is @radical 's #72815
lewing commentedon Jul 26, 2022
it is #72412 but yes that is blocked on wbt at the moment
radical commentedon Jul 27, 2022
The ref assemblies should be same for all the 3 variants, correct?
lambdageek commentedon Jul 27, 2022
we have extra ref assemblies (
Microsoft.NET.WebAssembly.ThreadingandSystem.Diagnostics.Tracing.WebAssembly.PerfTracing). Original plan was to place these in separate nugets that would get referenced when a user .csproj did some gesture. Does that make sense to do as part of the work you're doing?I tried this out and it seemed to work (compilation would use the ref assemblies from the nugets, not the ones in the base SDK)
if we're doing different runtime packs, I'm not sure if it's possible to place ref assemblies into the runtime packs directly. that might be simpler.
radical commentedon Jul 27, 2022
So, we need 3 ref pack nugets then?
radical commentedon Jul 27, 2022
We also need a few Wasm.Build.Tests to exercise using the threaded runtimes, and the extra ref assemblies.
lambdageek commentedon Jul 27, 2022
No? we need the SDK to add a PackageReference to one of the two new nugets when the corresponding runtime variant is selected that just has the handful of updated ref assemblies.
radical commentedon Jul 28, 2022
lambdageek commentedon Sep 14, 2022
This is now mostly done (see https://github.com/lambdageek/hithread)
I think the only remaining thing is to automatically add a
<PackageReference Include=Microsoft.NET.WebAssembly.Threading"/>that will pull in the threading-enabled reference assemblies which will quiet down the platform compatibility analyzer warnings about "unsupported" threading operationshttps://github.com/lambdageek/hithread/blob/f7118d19ac88472576bd55671a33cfe9e5c2c099/hithread.csproj#L25
[-]The browser-wasm SDK should support using multithread and perftrace runtime variants.[/-][+]The browser-wasm SDK should automatically reference the threading/perf-tracing ref assemblies[/+]lewing commentedon Jul 22, 2023
done