Repository navigation
False positive for SYSLIB1006 when user haven't specified EventID #72263
Description
Description
Related to discussion in #70147 (reply in thread)
CC: @davidfowl
SYSLIB1006 warning states that multiple logging methods cannot use the same event ID.
But it also fires when EventID isn't specified at all. I've annotated my methods without event id:
[LoggerMessage(Level = LogLevel.Information, Message = "Hi there")]
...
[LoggerMessage(Level = LogLevel.Information, Message = "Hi there2")]and still get a SYSLIB1006 warning.
Reproduction Steps
Shown above
Expected behavior
No warning or at least lower severity event
Actual behavior
Warning which fails the build (since we have Treat warnings as errors enabled)
Regression?
No
Known Workarounds
Disable the warning
Configuration
No response
Other information
No response
Activity
[-]Create a new `Info` level event instead of `SYSLIB1006` for cases where user haven't specified `EventID`[/-][+]False positive for `SYSLIB1006` when user haven't specified `EventID`[/+]havocbcn commentedon Aug 2, 2022
According to https://docs.microsoft.com/en-us/dotnet/core/extensions/logging?tabs=command-line#log-event-id
the same EventId could be repeated in different logs.
davidfowl commentedon Aug 2, 2022
Event ids are per category
ShreyasJejurkar commentedon May 1, 2023
When this would get addressed? I just now hit this issue!