Poor codegen for "big" (> 4 fields) structs init #71565

Activity

1. ghost added

   area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMICLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

   on Jul 1, 2022
2. ghost added

   untriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner

   on Jul 1, 2022
4. jakobbotsch commented on Jul 1, 2022

   

   jakobbotsch

   on Jul 1, 2022

   Member

   More actions

   This is essentially a duplicate of #6534 -- the JIT does not currently do promotion for structs with more than 4 fields. It is an area that I hope we will be improving in .NET 8.

   👍React with 👍2Reacted by hypeartist and Thorsten Sommer

   ❤️React with ❤️2Reacted by Tanner Gooding and Thorsten Sommer
5. hypeartist commented on Jul 1, 2022

   

   hypeartist

   on Jul 1, 2022

   Author

   More actions

   @jakobbotsch Is there any info about what are all those restrictions (#6494 (comment) especially the one about 4 fields limit) based on?
6. SingleAccretion commented on Jul 1, 2022

   

   SingleAccretion

   on Jul 1, 2022

   Contributor

   More actions

   The 4 fields limit is just a CQ heuristic. Some of the other restrictions represent unimplemented functionality.
7. hypeartist commented on Jul 1, 2022

   

   hypeartist

   on Jul 1, 2022

   Last edited by hypeartist

   Author

   More actions

   @jakobbotsch @SingleAccretion On the second thought my guess is that the issue some way related to ABI stuff - particularly the fact that the number of args that could be passed in regs is 4
8. hypeartist commented on Jul 5, 2022

   

   hypeartist

   on Jul 5, 2022

   Last edited by hypeartist

   Author

   More actions

   Another strangeness.
   Method M1C vs M1A. Both operate with the same 'big' struct A:

   

   PS: or even like this:

   
9. JulieLeeMSFT

   added

   questionAnswer questions and provide assistance, not an issue with source code or documentation.Answer questions and provide assistance, not an issue with source code or documentation.

   on Jul 5, 2022
10. JulieLeeMSFT

    assigned

    jakobbotsch

    on Jul 5, 2022
11. JulieLeeMSFT

    added this to the 7.0.0 milestone on Jul 11, 2022
12. ghost removed

    untriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner

    on Jul 11, 2022
13. jakobbotsch

    modified the milestones: 7.0.0, 8.0.0 on Jul 12, 2022
14. jakobbotsch

    added

    Priority:2Work that is important, but not critical for the releaseWork that is important, but not critical for the release

    on Jun 20, 2023
15. ghost added

    in-prThere is an active PR which will close this issue when it is mergedThere is an active PR which will close this issue when it is merged

    on Jun 27, 2023
16. jakobbotsch

    closed this as completedin #88090on Jun 29, 2023
17. jakobbotsch

    closed this as completedin 9dcc7b1on Jun 29, 2023
18. ghost removed

    in-prThere is an active PR which will close this issue when it is mergedThere is an active PR which will close this issue when it is merged

    on Jun 29, 2023
19. ghost locked as resolved and limited conversation to collaborators on Jul 29, 2023