Repository navigation
Remove P/invoke marshalling pregeneration from ReadyToRun. #69758
Description
https://github.com/dotnet/runtime/blob/4cc3808d9e3ad6a23fc8b0f1b167f532e9e2b067/docs/design/features/readytorun-pinvoke.md describes a mechanism where P/Invoke marshalling code for some common cases is generated ahead of time during ReadyToRun compilation.
Judging from the document this mechanism seems fragile and hard to maintain. Now that we have the LibraryImport source generator which is easier for ordinary R2R to take advantage of, this optimization is getting less relevant and maybe you should consider removing it for simplicity and ease of maintenance.
Reacted by Jan Kotas
Reacted by Jeremy Koritzinsky
Activity
trylek commentedon Jun 20, 2022
@jkoritzinsky, can you please clarify the delta between the PR you merged in and this issue i.o.w. what remains to be done here?
jkoritzinsky commentedon Jun 20, 2022
The remaining work is to actually remove the P/Invoke emit infra from crossgen2 (including blittable stub support), but this work depends on #70109.
mangod9 commentedon Jun 23, 2023
@jkoritzinsky is there work still pending around this which will be done in 8 or should this be moved to later?
trylek commentedon Jun 23, 2023
Please note that according to Jeremy the final work is blocked on #70109 and the last comment on that issue is one from @AaronRobinsonMSFT from last August where he suggests moving the issue from .NET 7 to .NET 8.
jkoritzinsky commentedon Jun 23, 2023
The rest of this work depends on either doing #70109 or #79125. I'll mark this as blockedIssue/PR is blocked on something - see comments
and Future for now.