system.reflection.tests.nullabilityinfocontexttests.nullablepubliconlyothertypestest #66100

Activity

1. ghost added

   untriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner

   on Mar 2, 2022
3. AaronRobinsonMSFT

   added

   area-System.Reflection

   on Mar 2, 2022
5. AaronRobinsonMSFT

   added

   blocking-clean-ciBlocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'

   on Mar 2, 2022
6. AaronRobinsonMSFT

   added this to the 7.0.0 milestone on Mar 2, 2022
7. AaronRobinsonMSFT commented on Mar 2, 2022

   

   AaronRobinsonMSFT

   on Mar 2, 2022

   Member

   More actions

   This is causing consistent issues across the repo. I am currently investigating on macOS.
8. AaronRobinsonMSFT commented on Mar 2, 2022

   

   AaronRobinsonMSFT

   on Mar 2, 2022

   Member

   More actions

   Still building. Here are the known parts.

   1. The test:

   [Fact]
   [SkipOnMono("Nullability attributes trimmed on Mono")]
   public void NullablePublicOnlyOtherTypesTest()
   {
       Type type = typeof(Type);
       FieldInfo privateNullableField = type.GetField("s_defaultBinder", flags)!;
       NullabilityInfo info = nullabilityContext.Create(privateNullableField); // <------ Failing here

   2. The value should exist on Type.

   public static Binder DefaultBinder
   {
       get
       {
           if (s_defaultBinder == null)
           {
               DefaultBinder binder = new DefaultBinder();
               Interlocked.CompareExchange<Binder?>(ref s_defaultBinder, binder, null);
           }
           return s_defaultBinder!;
       }
   }
   private static volatile Binder? s_defaultBinder;

   My only guess here is the trimmer might have done something? I was assured the trimmer should not run in this case, but I don't see how else this test would fail as follows:

       System.Reflection.Tests.NullabilityInfoContextTests.NullablePublicOnlyOtherTypesTest [FAIL]
         System.ArgumentNullException : Value cannot be null. (Parameter 'fieldInfo')
         Stack Trace:
              at <PrivateImplementationDetails>.Throw(String paramName)
              at <PrivateImplementationDetails>.ThrowIfNull(Object argument, String paramName)
              at System.Reflection.NullabilityInfoContext.Create(FieldInfo fieldInfo)
           /_/src/libraries/System.Runtime/tests/System/Reflection/NullabilityInfoContextTests.cs(763,0): at System.Reflection.Tests.NullabilityInfoContextTests.NullablePublicOnlyOtherTypesTest()
   
9. elinor-fung commented on Mar 2, 2022

   

   elinor-fung

   on Mar 2, 2022

   Member

   More actions

   I think this is actually from #65986, which removed the _code field from Regex
   cc @stephentoub

   The test does:
   

   runtime/src/libraries/System.Runtime/tests/System/Reflection/NullabilityInfoContextTests.cs

   Lines 762 to 763 in c0d481f

   	privateNullableField = regexType.GetField("_code", flags)!;
   	info = nullabilityContext.Create(privateNullableField);

   👍React with 👍1Reacted by Buyaa Namnan
10. AaronRobinsonMSFT commented on Mar 2, 2022

    

    AaronRobinsonMSFT

    on Mar 2, 2022

    Last edited by AaronRobinsonMSFT

    Member

    More actions

    @elinor-fung Hmmm. I must have missed something but based on the stack you must be correct. I am still unable to reproduce this locally though.

    Edit: I'm officially wearing the dunce hat today... I'm able to reproduce this locally and see the issue now.
11. stephentoub commented on Mar 2, 2022

    

    stephentoub

    on Mar 2, 2022

    Member

    More actions

    I think this is actually from #65986, which removed the _code field from Regex

    Ugh. I'll fix it. We shouldn't be relying on private fields like this across test suites :(
12. stephentoub commented on Mar 2, 2022

    

    stephentoub

    on Mar 2, 2022

    Member

    More actions

    This should be fixed by #66113

    👍React with 👍1Reacted by Buyaa Namnan
13. stephentoub

    closed this as completedon Mar 2, 2022
14. agocke

    removed

    untriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner

    on Mar 3, 2022
15. ghost locked as resolved and limited conversation to collaborators on Apr 3, 2022