You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
System.Text.Json.SourceGeneration.Tests have issues with BigInteger and records on netfx #63802
Following issues were found when enabling netfx tests:
Whenever:
[JsonSerializable(typeof(ClassWithUnsupportedBigInteger))]
// and couple of other BigInteger related classes
is used the code no longer compiles - code generator seem to be generating code which tries to access private fields. Search for #if !NETFRAMEWORK in that code - this have been removed for netfx for now to unblock remainder of the tests
also JsonIgnoreAttribute_UnsupportedBigInteger is not passing - expected exception seem to differ. See test with ActiveIssue.
Another issues I'm seeing are InvalidOperationException (emit fails in CreateAssemblyImage in the test code), following tests are affected:
System.Text.Json.SourceGeneration.Tests.JsonSerializerContextTests.Converters_AndTypeInfoCreator_NotRooted_WhenMetadataNotPresent (I'm not able to reproduce this one locally)
Note: this issue is related to the PR which is not merged yet so some details reated to ActiveIssue or DefineConstants are relevant after merging it. (I need ActiveIssue number in order to finish PR)
changed the title [-]System.Text.Json.SourceGeneration.Tests have issues with BigInteger on netfx[/-][+]System.Text.Json.SourceGeneration.Tests have issues with BigInteger and records on netfx[/+]on Jan 17, 2022
The BigInteger failures were fixed by #87383 and the record unit tests are caused by the fact that netfx doesn't have the IsExternalInit class defined. I'll follow up with a PR enabling the tests and closing the issue.
Activity
[-]System.Text.Json.SourceGeneration.Tests have issues with BigInteger on netfx[/-][+]System.Text.Json.SourceGeneration.Tests have issues with BigInteger and records on netfx[/+]eiriktsarpalis commentedon Jun 15, 2023
The BigInteger failures were fixed by #87383 and the record unit tests are caused by the fact that netfx doesn't have the
IsExternalInitclass defined. I'll follow up with a PR enabling the tests and closing the issue.