Repository navigation
System.Diagnostics.Tests.ProcessTests.TestToString_OnExitedProcess failing in the CI #56649
Description
C:\h\w\A9F70974\w\A2CA08DC\e>"C:\h\w\A9F70974\p\dotnet.exe" exec --runtimeconfig System.Diagnostics.Process.Tests.runtimeconfig.json --depsfile System.Diagnostics.Process.Tests.deps.json xunit.console.dll System.Diagnostics.Process.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing
Discovering: System.Diagnostics.Process.Tests (method display = ClassAndMethod, method display options = None)
Discovered: System.Diagnostics.Process.Tests (found 254 of 278 test cases)
Starting: System.Diagnostics.Process.Tests (parallel test collections = on, max threads = 2)
System.Diagnostics.Tests.ProcessStartInfoTests.ShellExecute_Nano_Fails_Start [SKIP]
Condition(s) not met: "IsWindowsNanoServer"
System.Diagnostics.Tests.ProcessTests.TestToString_OnExitedProcess [FAIL]
Assert.Equal() Failure
? (pos 26)
Expected: ....Diagnostics.Process
Actual: ....Diagnostics.Process (dotnet)
? (pos 26)
Stack Trace:
/_/src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs(492,0): at System.Diagnostics.Tests.ProcessTests.TestToString_OnExitedProcess()
Invalid number of parameters
Activity
danmoseley commentedon Jul 30, 2021
Before calling ToString() the test calls WaitForExit(), which it asserted returned true. WaitForExit() is implemented by getting the process handle and waiting for it to be signaled.
Inside ToString(), the code calls ProcessManager.GetProcessInfo(..) --> NtProcessInfoHelper.GetProcessInfos(processId) --> NtQuerySystemInformation passing SystemProcessInformation (0x05) which returns an array of SYSTEM_PROCESS_INFORMATION. If the PID is in that array, it uses the process name (from ImageName in the struct) to append to the result.
This failure suggests that despite the process handle being signaled, NtQuerySystemInformation returned it. We know this is flaky, since it passed when we committed this test.
In the absence of better ideas, short of a sleep, we should modify the test to accept either output since it really doesn't matter much.