Repository navigation
R2R jobs should not pass -O to crossgen2 #56148
Description
When -O is passed, crossgen2 will ignore the assembly's "debug" bit. We have some JIT tests that rely on this bit to be respected which are currently disabled because of this behavior since our R2R jobs pass -O. Some more discussion in #55062.
cc @dotnet/crossgen-contrib
Activity
MichalStrehovsky commentedon Jul 22, 2021
The jobs should be changed not to pass
-O. The-Owas required to optimize before #44514 got merged.The
-Owas supposed to be removed per #44514 (comment) but it probably slipped through the cracks.[-]Crossgen2 ignores assembly "debug" bit when -O is passed[/-][+]R2R jobs should not pass -O to crossgen2[/+]jakobbotsch commentedon Jul 22, 2021
The -O parameter was readded in #49867 it looks like.
MichalStrehovsky commentedon Jul 22, 2021
Ah okay, I don't know what going on there then. I'll leave that to the crossgen team.
mangod9 commentedon Jul 26, 2021
@jakobbotsch, is this a blocker for .net 6?
jakobbotsch commentedon Jul 26, 2021
@mangod9 No, the test is just disabled for R2R jobs at the moment. Reenabling it can wait.
mangod9 commentedon Jul 26, 2021
Ok thanks will move to 7
davidwrighton commentedon Jul 6, 2022
Consider doing this during the downtime between 7 and 8.
ivdiazsa commentedon Jul 6, 2023
Just to confirm, should we stop passing
-Oaltogether to crossgen2, or just for the R2R jobs?davidwrighton commentedon Jul 6, 2023
Looking at Simon's original change it appears he didn't handle the composite case, so composite builds might still need explicit control. I'd like you to look into that and verify if you make a change here, that we don't regress composite compilation. In addition, if we are going to disable passing -O to crossgen2 in our tests, we should probably consider not passing it in the SDK, so we would need to validate all of our scenarios continue to work correctly if we do that.