[Perf] Regression in Xml_ToStream Serializers #56016

Activity

1. DrewScoggins

   added

   os-windows

   tenet-performancePerformance related issuePerformance related issue

   tenet-performance-benchmarksIssue from performance benchmarkIssue from performance benchmark

   arch-x64

   on Jul 20, 2021
3. ghost added

   untriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner

   on Jul 20, 2021
4. DrewScoggins commented on Jul 20, 2021

   

   DrewScoggins

   on Jul 20, 2021

   MemberAuthor

   More actions

   Seems related to #55101
5. DrewScoggins commented on Jul 20, 2021

   

   DrewScoggins

   on Jul 20, 2021

   MemberAuthor

   More actions

   Improvement:

   Run Information

   Architecture	x64
   OS	Windows 10.0.18362
   Baseline	71d0d2b275efa091f235c569f01869f39bfb7638
   Compare	e983168f871dcba090ff6ec08c0d2c7d4353fb8e
   Diff	Diff

   Improvemnts in MicroBenchmarks.Serializers.Xml_FromStream<MyEventsListerViewModel>

   Benchmark	Baseline	Test	Test/Base	Test Quality	Edge Detector	Baseline IR	Compare IR	IR Ratio	Baseline ETL	Compare ETL
   XmlSerializer_ - Duration of single invocation	1.17 ms	895.25 μs	0.77	0.01	True

   
   Historical Data in Reporting System

   Repro

   git clone https://github.com/dotnet/performance.git
   py .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'MicroBenchmarks.Serializers.Xml_FromStream<MyEventsListerViewModel>*'

   Details

   Payloads

   Baseline
   Compare

   Histogram

   MicroBenchmarks.Serializers.Xml_FromStream<MyEventsListerViewModel>.XmlSerializer_

   Docs

   Profiling workflow for dotnet/runtime repository
   Benchmarking workflow for dotnet/runtime repository

   ### Run Information

   Architecture	x64
   OS	Windows 10.0.18362
   Baseline	71d0d2b275efa091f235c569f01869f39bfb7638
   Compare	e983168f871dcba090ff6ec08c0d2c7d4353fb8e
   Diff	Diff

   Improvemnts in MicroBenchmarks.Serializers.Xml_FromStream<IndexViewModel>

   Benchmark	Baseline	Test	Test/Base	Test Quality	Edge Detector	Baseline IR	Compare IR	IR Ratio	Baseline ETL	Compare ETL
   XmlSerializer_ - Duration of single invocation	102.70 μs	88.16 μs	0.86	0.01	False

   
   Historical Data in Reporting System

   Repro

   git clone https://github.com/dotnet/performance.git
   py .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'MicroBenchmarks.Serializers.Xml_FromStream<IndexViewModel>*'

   Details

   Payloads

   Baseline
   Compare

   Histogram

   MicroBenchmarks.Serializers.Xml_FromStream<IndexViewModel>.XmlSerializer_

   Docs

   Profiling workflow for dotnet/runtime repository
   Benchmarking workflow for dotnet/runtime repository
6. mconnew commented on Jul 20, 2021

   

   mconnew

   on Jul 20, 2021

   Member

   More actions

   @DrewScoggins, #55101 wouldn't have caused a regression unless the types being serialized contain DateTimeOffset properties. If that's the case, then the regression is okay as we're doing more work as we're now actually serializing DateTimeOffset now. If there's no DateTimeOffset properties involved, then the problem was somewhere else.
7. DrewScoggins commented on Jul 20, 2021

   

   DrewScoggins

   on Jul 20, 2021

   Last edited by DrewScoggins

   MemberAuthor

   More actions

   OK, those types do have DateTimeOffset. Before #55101 we were not doing the serialization at all, and now we are? If that is the case then seems like a regression would be expected.
8. mconnew commented on Jul 20, 2021

   

   mconnew

   on Jul 20, 2021

   Member

   More actions

   Yes, that is exactly the case. Previously it would serialize as an empty XML element. Now it will output an XML format date time, and will deserialize it too.
9. stephentoub commented on Jul 21, 2021

   

   stephentoub

   on Jul 21, 2021

   Member

   More actions

   Closing as expected / by-design. Thanks.
10. stephentoub

    closed this as completedon Jul 21, 2021
11. ghost locked as resolved and limited conversation to collaborators on Aug 20, 2021