AF: (SIZE_T)mtype < COUNTOF(nativeSizes) when building COM vtable #53110

Activity

1. ghost added

   untriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner

   on May 21, 2021
3. tarekgh

   changed the title [-]CI Assert failure in System.Runtime.Tests[/-] [+]CI Assert failure when starting System.Runtime.Tests[/+] on May 21, 2021
4. jkotas commented on May 21, 2021

   

   jkotas

   on May 21, 2021

   Member

   More actions

   The pattern leading to this assert: #52992 (comment)

   Stack trace:

   03 0b35c7cc 720feb0c coreclr!DbgAssertDialog+0x20b [D:\workspace\_work\1\s\src\coreclr\utilcode\debug.cpp @ 695] 
   04 0b35c848 7210288c coreclr!MarshalInfo::GetNativeSize+0x99 [D:\workspace\_work\1\s\src\coreclr\vm\mlinfo.cpp @ 2931] 
   05 0b35c8bc 72224f6b coreclr!MarshalInfo::SetupArgumentSizes+0xc9 [D:\workspace\_work\1\s\src\coreclr\vm\mlinfo.cpp @ 2903] 
   06 0b35cc44 722249c5 coreclr!ComCallMethodDesc::InitNativeInfo+0x3aa [D:\workspace\_work\1\s\src\coreclr\vm\comtoclrcall.cpp @ 1043] 
   07 0b35ccec 7220df3c coreclr!ComCallMethodDesc::InitField+0x191 [D:\workspace\_work\1\s\src\coreclr\vm\comtoclrcall.cpp @ 977] 
   08 0b35d068 72205ec8 coreclr!ComMethodTable::LayOutClassMethodTable+0x926 [D:\workspace\_work\1\s\src\coreclr\vm\comcallablewrapper.cpp @ 3505] 
   09 0b35d124 7220463e coreclr!ComCallWrapper::GetIClassXIP+0x1fc [D:\workspace\_work\1\s\src\coreclr\vm\comcallablewrapper.cpp @ 2341] 
   0a 0b35d1ec 72203db1 coreclr!GetComIPFromCCW_ForIntfMT_Worker+0x2e3 [D:\workspace\_work\1\s\src\coreclr\vm\comcallablewrapper.cpp @ 2649] 
   0b 0b35d2c8 72086eb9 coreclr!ComCallWrapper::GetComIPFromCCW+0x4aa [D:\workspace\_work\1\s\src\coreclr\vm\comcallablewrapper.cpp @ 2813] 
   0c 0b35d420 72098e22 coreclr!GetComIPFromObjectRef+0x649 [D:\workspace\_work\1\s\src\coreclr\vm\interopconverter.cpp @ 132] 
   0d 0b35d49c 7218902c coreclr!MarshalObjectToInterface+0xda [D:\workspace\_work\1\s\src\coreclr\vm\interoputil.cpp @ 4224] 
   0e 0b35d570 0b5fb2ee coreclr!StubHelpers::InterfaceMarshaler__ConvertToNative+0xdc [D:\workspace\_work\1\s\src\coreclr\vm\stubhelpers.cpp @ 432] 
   0f 0b35d5d0 0b5fb202 System_IO_FileSystem!ILStubClass.IL_STUB_PInvoke(EnumUILanguagesProc, UInt32, EnumContext)+0x46
   
5. jkotas

   added

   area-Interop-coreclr

   on May 21, 2021
6. tarekgh commented on May 21, 2021

   

   tarekgh

   on May 21, 2021

   MemberAuthor

   More actions

   @jkotas we have reverted the original change showed the failure. Should we keep this issue open to fix from the runtime side? or you think nothing need to be done in the runtime side?
7. jkotas commented on May 21, 2021

   

   jkotas

   on May 21, 2021

   Member

   More actions

   Yes, we should keep this issue open to fix the assert.

   👍React with 👍1Reacted by Aaron R Robinson
8. jkotas

   changed the title [-]CI Assert failure when starting System.Runtime.Tests[/-] [+]AF: (SIZE_T)mtype < COUNTOF(nativeSizes) when building COM vtable[/+] on May 21, 2021
9. AaronRobinsonMSFT

   removed

   untriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner

   on May 22, 2021
10. AaronRobinsonMSFT

    added this to the 6.0.0 milestone on May 22, 2021
11. AaronRobinsonMSFT commented on May 22, 2021

    

    AaronRobinsonMSFT

    on May 22, 2021

    Member

    More actions

    This has no issue on 64-bit. Just noticed the pointers are all 32-bit so switching to x86 build.
12. AaronRobinsonMSFT

    added

    arch-x86

    os-windows

    on May 22, 2021
13. AaronRobinsonMSFT commented on May 22, 2021

    

    AaronRobinsonMSFT

    on May 22, 2021

    Member

    More actions

    Confirmed this is only an x86 bug.
14. AaronRobinsonMSFT commented on May 22, 2021

    

    AaronRobinsonMSFT

    on May 22, 2021

    Member

    More actions

    @jkoritzinsky Can you take a look at this. After taking a closer look here I agree with @jkotas that this should have failed in all cases. The field in question is a List<CultureInfo>. We are in a weird position here since we assert on x86 indicating the native type is unknown (correctly) whereas on Amd64 we don't perform the same field offset computation and just "do it".

    The below code is why x86 is failing - specifically line 1040 because the MarshalInfo has determined the field is generic, marks the error resource ID, and sets the type as MARSHAL_TYPE_UNKNOWN. This is what asserts when trying to compute the native size of the field in MarshalInfo::GetNativeSize().

    runtime/src/coreclr/vm/comtoclrcall.cpp

    Lines 1016 to 1045 in 34dff2d

    	#ifdef TARGET_X86
    	MetaSig fsig(pFD);
    	fsig.NextArg();
    	// Look up the best fit mapping info via Assembly & Interface level attributes
    	BOOL BestFit = TRUE;
    	BOOL ThrowOnUnmappableChar = FALSE;
    	ReadBestFitCustomAttribute(fsig.GetModule(), pFD->GetEnclosingMethodTable()->GetCl(), &BestFit, &ThrowOnUnmappableChar);
    	MarshalInfo info(fsig.GetModule(), fsig.GetArgProps(), fsig.GetSigTypeContext(), pFD->GetMemberDef(), MarshalInfo::MARSHAL_SCENARIO_COMINTEROP,
    	(CorNativeLinkType)0, (CorNativeLinkFlags)0,
    	FALSE, 0, fsig.NumFixedArgs(), BestFit, ThrowOnUnmappableChar, FALSE, NULL, FALSE
    	#ifdef _DEBUG
    	, szDebugName, szDebugClassName, 0
    	#endif
    	);
    	if (IsFieldGetter())
    	{
    	// getter takes 'this' and the output argument by-ref
    	nativeArgSize = sizeof(void *) + sizeof(void *);
    	}
    	else
    	{
    	info.SetupArgumentSizes();
    	// setter takes 'this' and the input argument by-value
    	nativeArgSize = sizeof(void *) + info.GetNativeArgSize();
    	}
    	#endif // TARGET_X86

    The repro is simple on Windows x86.

    public unsafe class Program
    {
        static void Main(string[] args)
        {
            var context = new EnumContext();
            EnumUILanguagesProc proc = EnumUiLanguagesCallback;
    
            EnumUILanguages(proc, MUI_ALL_INSTALLED_LANGUAGES | MUI_LANGUAGE_NAME, context);
            GC.KeepAlive(proc);
        }
    
        private static bool EnumUiLanguagesCallback(IntPtr lpUiLanguageString, EnumContext lParam)
        {
            Console.WriteLine($"{nameof(EnumUiLanguagesCallback)}");
            var cultureName = Marshal.PtrToStringUni(lpUiLanguageString);
            if (cultureName != null)
            {
                lParam.InstalledCultures.Add(CultureInfo.GetCultureInfo(cultureName));
                return true;
            }
    
            return false;
        }
    
        private const uint MUI_LANGUAGE_NAME = 0x8;
        private const uint MUI_ALL_INSTALLED_LANGUAGES = 0x20;
    
        [DllImport("Kernel32.dll", CharSet = CharSet.Auto)]
        private static extern bool EnumUILanguages(EnumUILanguagesProc lpUILanguageEnumProc, uint dwFlags, EnumContext lParam);
    
        private delegate bool EnumUILanguagesProc(IntPtr lpUILanguageString, EnumContext lParam);
    
        private class EnumContext
        {
            // Marshalling this field is invalid but on Amd64 we ignore it and on x86
            // we assert or will index into random memory.
            public readonly List<CultureInfo> InstalledCultures = new();
        }
    }
15. AaronRobinsonMSFT

    removed

    arch-x86

    on May 22, 2021
16. ghost added

    in-prThere is an active PR which will close this issue when it is mergedThere is an active PR which will close this issue when it is merged

    on May 24, 2021
17. AaronRobinsonMSFT

    closed this as completedin #53194on Jun 8, 2021
18. ghost removed

    in-prThere is an active PR which will close this issue when it is mergedThere is an active PR which will close this issue when it is merged

    on Jun 8, 2021
19. ghost locked as resolved and limited conversation to collaborators on Jul 8, 2021