Repository navigation
CI is currently broken "You cannot extract a file outside of the target path" #52596
Description
I'm seeing this same error on multiple PRs:
Downloading artifact CoreCLRProduct___windows_arm64_release from: https://dev.azure.com/dnceng//9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_apis/build/builds/1132154/artifacts?artifactName=CoreCLRProduct___windows_arm64_release&$format=zip
Downloading to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Downloaded to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Total Files: 1, Processed: 1, Skipped: 0, Failed: 0, Download time: 21.079 secs, Download size: 0Bytes
Starting artifact items integrity check
Artifact items integrity check successfully finished
Error: in Download zip - CoreCLRProduct___windows_arm64_release, so retrying => retries pending : 4
Downloading artifact CoreCLRProduct___windows_arm64_release from: https://dev.azure.com/dnceng//9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_apis/build/builds/1132154/artifacts?artifactName=CoreCLRProduct___windows_arm64_release&$format=zip
Downloading to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Downloaded to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Total Files: 1, Processed: 1, Skipped: 0, Failed: 0, Download time: 23.103 secs, Download size: 0Bytes
Starting artifact items integrity check
Artifact items integrity check successfully finished
Error: in Download zip - CoreCLRProduct___windows_arm64_release, so retrying => retries pending : 3
Downloading artifact CoreCLRProduct___windows_arm64_release from: https://dev.azure.com/dnceng//9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_apis/build/builds/1132154/artifacts?artifactName=CoreCLRProduct___windows_arm64_release&$format=zip
Downloading to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Downloaded to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Total Files: 1, Processed: 1, Skipped: 0, Failed: 0, Download time: 23.132 secs, Download size: 0Bytes
Starting artifact items integrity check
Artifact items integrity check successfully finished
Error: in Download zip - CoreCLRProduct___windows_arm64_release, so retrying => retries pending : 2
Downloading artifact CoreCLRProduct___windows_arm64_release from: https://dev.azure.com/dnceng//9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_apis/build/builds/1132154/artifacts?artifactName=CoreCLRProduct___windows_arm64_release&$format=zip
Downloading to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Downloaded to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Total Files: 1, Processed: 1, Skipped: 0, Failed: 0, Download time: 27.139 secs, Download size: 0Bytes
Starting artifact items integrity check
Artifact items integrity check successfully finished
Error: in Download zip - CoreCLRProduct___windows_arm64_release, so retrying => retries pending : 1
Downloading artifact CoreCLRProduct___windows_arm64_release from: https://dev.azure.com/dnceng//9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_apis/build/builds/1132154/artifacts?artifactName=CoreCLRProduct___windows_arm64_release&$format=zip
Downloading to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Downloaded to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Total Files: 1, Processed: 1, Skipped: 0, Failed: 0, Download time: 21.118 secs, Download size: 0Bytes
Starting artifact items integrity check
Artifact items integrity check successfully finished
##[error]Failed in Download zip - CoreCLRProduct___windows_arm64_release with error: Failed to extract package with error Error: You cannot extract a file outside of the target path
Successfully downloaded artifacts to D:\workspace\_work\1\s/__download__
##[error]Failed to extract package with error Error: You cannot extract a file outside of the target path
Runfo Tracking Issue: Failure to extract packages
| Definition | Build | Kind | Job Name |
|---|
Build Result Summary
| Day Hit Count | Week Hit Count | Month Hit Count |
|---|---|---|
| 0 | 0 | 0 |
Activity
Chrisboh commentedon May 11, 2021
@dotnet/dnceng could you take a look at this and see if this is part of the AzDo issues we are currently seeing?
ericstj commentedon May 11, 2021
Has anyone inspected the ZIP to see if it has malformed entries? Things like a rooted (\foo) or relative (..) archive entry might cause that error.
jaredpar commentedon May 11, 2021
Seeing 700+ hits over last seven days
https://runfo.azurewebsites.net/search/timelines/?q=started%3A%7E7+definition%3Aruntime+message%3A%22You+cannot+extract+a+file+outside+of+the+target+path%22
hoyosjs commentedon May 11, 2021
Also, a quick scan through the hits I saw on runfo - all of them seem to be on Windows. Before most of our corruption at download was seen on Linux/macOS. @ericstj this is at download time, so unlikely. The only validation done at this stage on the artifact is that the file size matches the size in the manifest (this was added in microsoft/azure-pipelines-tasks#14065). I am wondering if the asset manifest is correct here, or if it matches whatever typescript considers to be file size when checking the artifact in https://github.com/microsoft/azure-pipelines-tasks/blob/c9771bc064cd60f47587c68e5c871b7cd13f0f28/Tasks/DownloadBuildArtifactsV0/download_helper.ts#L37.
chcosta commentedon May 11, 2021
Thanks for reporting this, I'm taking a look.
hoyosjs commentedon May 11, 2021
@chcosta I just checked this manually. The manifest size and the size reported by powershell on the asset reported in the issue and they do differ quite a bit: 208496577 in manifest vs 207457787 in pwsh.
chcosta commentedon May 11, 2021
Seems weird to me that the artifact is a zip that has a folder which contains a zip that has the contents. I'm trying to understand how the runtime repo is packaging these artifacts, but it's taking me a while to sort through the mass of yamls.
hoyosjs commentedon May 11, 2021
You can take a look at
eng\pipelines\common\upload-artifact-step.yml. There's an equivalent download one on the same folder.hoyosjs commentedon May 11, 2021
You're right, the zip inside does have the expected size - 208496577. However, the task link for the reported failed download gives me a zip with the wrong size. I wonder if they are checking the size prior to decompression and that's why it fails.
chcosta commentedon May 11, 2021
Created ICM ticket - https://portal.microsofticm.com/imp/v3/incidents/details/240668523/home
chcosta commentedon May 11, 2021
Azdo has made a rollback of an update, and Juan is monitoring to ensure the issue is resolved. If it's not, we'll jump on another call tomorrow.
hoyosjs commentedon May 12, 2021
Removing blocking CI. No new instances have been spotted since the rollback happened.
sandreenko commentedon May 12, 2021
Is it a different issue https://dev.azure.com/dnceng/public/_build/results?buildId=1135727&view=results? Started today at 3:21 PM
hoyosjs commentedon May 12, 2021
@sandreenko yes. Different issue. The other one was a Windows only issue. Taking a quick look.
hoyosjs commentedon May 12, 2021
Have you seen it in multiple PRs? I see they appear to have tried to fix the task and updated it. But I don't see any other instances except one from over a week ago.
sandreenko commentedon May 13, 2021
No, I saw it in my PR after I added a commit to it, the neighbor runs did not have this issue.
ViktorHofer commentedon Sep 7, 2021
Closing as resolved.