Tasks issues on Mac Catalyst #52460

Activity

1. directhex

   added

   area-VM-threading-mono

   os-maccatalystMacCatalyst OSMacCatalyst OS

   on May 7, 2021
2. ghost added

   untriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner

   on May 7, 2021
3. steveisok commented on May 7, 2021

   

   steveisok

   on May 7, 2021

   Member

   More actions

   /cc @lambdageek
4. marek-safar

   assigned

   lambdageek

   on May 7, 2021
5. marek-safar

   removed

   untriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner

   on May 7, 2021
6. marek-safar

   added this to the 6.0.0 milestone on May 7, 2021
7. steveisok

   modified the milestones: 6.0.0, 7.0.0 on Aug 16, 2021
8. lambdageek commented on Aug 16, 2021

   

   lambdageek

   on Aug 16, 2021

   Member

   More actions

   Fails in various ways, but the upshot seems to be that a LowLevelLifoSemaphore (probably s_semaphore in PortableThreadPool.WorkerThread is not initialized when methods are called on it.

   Sometimes we get a null sem_ptr in

   gint32
   ves_icall_System_Threading_LowLevelLifoSemaphore_TimedWaitInternal (gpointer sem_ptr, gint32 timeout_ms)
   

   Sometimes instead the TimedWait throws a NRE, or sometimes there's an access violation.

   It seems like PortableThreadPool.WorkerThread.WorkerThreadStart sees a null s_semaphore sometimes. Not clear how that can happen - or why it only happens on catalyst.
9. lambdageek commented on Sep 24, 2021

   

   lambdageek

   on Sep 24, 2021

   Member

   More actions

   This is failing because there are two tests disabled with [ActiveIssue("...", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoInterpreter))]

   runtime/src/libraries/System.Threading.Tasks.Dataflow/tests/Dataflow/DataflowBlockExtensionTests.cs

   Line 1125 in 2e08554

   [ActiveIssue("https://github.com/dotnet/runtime/issues/38817", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoInterpreter))]

   and

   runtime/src/libraries/System.Threading.Tasks.Dataflow/tests/Dataflow/DataflowBlockExtensionTests.cs

   Line 1927 in 2e08554

   [ActiveIssue("https://github.com/dotnet/runtime/issues/38817", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoInterpreter))]

   The problem is that GetIsRunningOnMonoInterpreter is wrong on mobile (including catalyst) - we don't set the MONO_ENV_OPTIONS variable to turn on the interpreter, we use the embedding API.

   runtime/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs

   Lines 467 to 477 in 2e08554

   	private static bool GetIsRunningOnMonoInterpreter()
   	{
   	#if NETCOREAPP
   	if (IsBrowser)
   	return RuntimeFeature.IsDynamicCodeSupported;
   	#endif
   	// This is a temporary solution because mono does not support interpreter detection
   	// within the runtime.
   	var val = Environment.GetEnvironmentVariable("MONO_ENV_OPTIONS");
   	return (val != null && val.Contains("--interpreter"));
   	}

   So the fix is to do correct interpreter detection.
10. ghost added

    in-prThere is an active PR which will close this issue when it is mergedThere is an active PR which will close this issue when it is merged

    on Sep 24, 2021
11. lambdageek

    closed this as completedin #59587on Sep 25, 2021
12. ghost removed

    in-prThere is an active PR which will close this issue when it is mergedThere is an active PR which will close this issue when it is merged

    on Sep 25, 2021
13. ghost locked as resolved and limited conversation to collaborators on Nov 3, 2021
14. danmoseley commented on Dec 16, 2021

    

    danmoseley

    on Dec 16, 2021

    Contributor

    More actions

    @lambdageek I happened to notice that this issue is closed but we are still excluding tests against it

    runtime/src/libraries/tests.proj

    Line 263 in 8a498cc

    <!-- Crashes randomly during test runs https://github.com/dotnet/runtime/issues/52460 -->