Skip to content

[wasm][tests][aot] Tests failing due to stacktrace not supported #50957

Open
Open
[wasm][tests][aot] Tests failing due to stacktrace not supported#50957
Assignees
BrzVlad
Labels
arch-wasmWebAssembly architecturearea-Codegen-AOT-monodisabled-testThe test is disabled in source code against the issuewasm-aot-testWebAssembly AOT Test
Milestone
Future

Description

@radical
radical
opened on Apr 8, 2021

Tests failing due to stacktrace APIs not being supported. The relevant tests are disabled.

-- System.Diagnostics.Tests
Logs

[19:39:33] fail: [FAIL] System.Diagnostics.Tests.StackFrameExtensionsTests.HasMethod_Invoke_ReturnsExpected(stackFrame: <null>
[19:39:33] info: , expected: True)
[19:39:33] info: Assert.Equal() Failure
[19:39:33] info: Expected: True
[19:39:33] info: Actual:   False
[19:39:33] info: 
[19:39:33] info: , expected: False)
[19:39:33] info: )
[19:39:33] info: )
[19:39:33] info: )
[19:39:33] info: )
[19:39:33] info: )
[19:39:33] info: )
[19:39:33] info: , expected: False)
[19:39:33] info: , expected: True)
[19:39:33] info: , expected: False)
[19:39:33] fail: [FAIL] System.Diagnostics.Tests.StackFrameExtensionsTests.HasILOffset_Invoke_ReturnsExpected(stackFrame: <null>
[19:39:33] info: , expected: True)
[19:39:33] info: Assert.Equal() Failure
[19:39:33] info: Expected: True
[19:39:33] info: Actual:   False
[19:39:33] info: 
[19:39:33] info: , expected: False)
[19:39:34] fail: [FAIL] System.Diagnostics.Tests.StackTraceTests.Ctor_Bool_ThrownException_GetFramesReturnsExpected(fNeedFileInfo: True)
[19:39:34] info: Assert.True() Failure
[19:39:34] info: Expected: True
[19:39:34] info: Actual:   False
[19:39:34] info: 
[19:39:34] fail: [FAIL] System.Diagnostics.Tests.StackTraceTests.Ctor_Bool_ThrownException_GetFramesReturnsExpected(fNeedFileInfo: False)
[19:39:34] info: Assert.True() Failure
[19:39:34] info: Expected: True
[19:39:34] info: Actual:   False
[19:39:34] info: 
[19:39:34] fail: [FAIL] System.Diagnostics.Tests.StackTraceTests.Ctor_SkipFrames(skipFrames: 0)
[19:39:34] info: Assert.True() Failure
[19:39:34] info: Expected: True
[19:39:34] info: Actual:   False
[19:39:34] info: 
[19:39:34] fail: [FAIL] System.Diagnostics.Tests.StackTraceTests.Ctor_SkipFrames(skipFrames: 1)
[19:39:34] info: Assert.Equal() Failure
[19:39:34] info: Expected: -1
[19:39:34] info: Actual:   0
[19:39:34] info: 
[19:39:34] info: )
[19:39:34] fail: [FAIL] System.Diagnostics.Tests.StackTraceTests.Ctor_Default
[19:39:34] info: Assert.True() Failure
[19:39:34] info: Expected: True
[19:39:34] info: Actual:   False
[19:39:34] info: 
[19:39:34] fail: [FAIL] System.Diagnostics.Tests.StackTraceTests.Ctor_ThrownException_GetFramesReturnsExpected
[19:39:34] info: Assert.True() Failure
[19:39:34] info: Expected: True
[19:39:34] info: Actual:   False
[19:39:34] info: 
[19:39:34] fail: [FAIL] System.Diagnostics.Tests.StackTraceTests.Ctor_FNeedFileInfo(fNeedFileInfo: True)
[19:39:34] info: Assert.True() Failure
[19:39:34] info: Expected: True
[19:39:34] info: Actual:   False
[19:39:34] info: 
[19:39:34] fail: [FAIL] System.Diagnostics.Tests.StackTraceTests.Ctor_FNeedFileInfo(fNeedFileInfo: False)
[19:39:34] info: Assert.True() Failure
[19:39:34] info: Expected: True
[19:39:34] info: Actual:   False
[19:39:34] info: 
[19:39:34] fail: [FAIL] System.Diagnostics.Tests.StackTraceTests.Ctor_SkipFrames_FNeedFileInfo(skipFrames: 0, fNeedFileInfo: True)
[19:39:34] info: Assert.True() Failure
[19:39:34] info: Expected: True
[19:39:34] info: Actual:   False
[19:39:34] info: 
[19:39:34] fail: [FAIL] System.Diagnostics.Tests.StackTraceTests.Ctor_SkipFrames_FNeedFileInfo(skipFrames: 1, fNeedFileInfo: True)
[19:39:34] info: Assert.Equal() Failure
[19:39:34] info: Expected: -1
[19:39:34] info: Actual:   0
[19:39:34] info: 
[19:39:34] fail: [FAIL] System.Diagnostics.Tests.StackTraceTests.Ctor_SkipFrames_FNeedFileInfo(skipFrames: 0, fNeedFileInfo: False)
[19:39:34] info: Assert.True() Failure
[19:39:34] info: Expected: True
[19:39:34] info: Actual:   False
[19:39:34] info: 
[19:39:34] fail: [FAIL] System.Diagnostics.Tests.StackTraceTests.Ctor_SkipFrames_FNeedFileInfo(skipFrames: 1, fNeedFileInfo: False)
[19:39:34] info: Assert.Equal() Failure
[19:39:34] info: Expected: -1
[19:39:34] info: Actual:   0
[19:39:34] info: 
[19:39:34] fail: [FAIL] System.Diagnostics.Tests.StackFrameTests.SkipFrames_CallMethod_ReturnsExpected
[19:39:34] info: Assert.Equal() Failure
[19:39:34] info: Expected: Void SkipFrames_CallMethod_ReturnsExpected()
[19:39:34] info: Actual:   (null)
[19:39:34] info: 
[19:39:34] fail: [FAIL] System.Diagnostics.Tests.StackFrameTests.Ctor_Default
[19:39:34] info: Expected GetILOffset() -1 for <null>
[19:39:34] info:  to be greater or equal to zero.
[19:39:34] info: Expected: True
[19:39:34] info: Actual:   False
[19:39:34] info: 
[19:39:34] fail: [FAIL] System.Diagnostics.Tests.StackFrameTests.Ctor_FNeedFileInfo(fNeedFileInfo: True)
[19:39:34] info: Expected GetILOffset() -1 for <null>
[19:39:34] info:  to be greater or equal to zero.
[19:39:34] info: Expected: True
[19:39:34] info: Actual:   False
[19:39:34] info: 
[19:39:34] fail: [FAIL] System.Diagnostics.Tests.StackFrameTests.Ctor_FNeedFileInfo(fNeedFileInfo: False)
[19:39:34] info: Expected GetILOffset() -1 for <null>
[19:39:34] info:  to be greater or equal to zero.
[19:39:34] info: Expected: True
[19:39:34] info: Actual:   False
[19:39:34] info: 
[19:39:34] fail: [FAIL] System.Diagnostics.Tests.StackFrameTests.Ctor_Filename_LineNumber(fileName: null, lineNumber: -1)
[19:39:34] info: Expected GetILOffset() -1 for <null>
[19:39:34] info:  to be greater or equal to zero.
[19:39:34] info: Expected: True
[19:39:34] info: Actual:   False
[19:39:34] info: 
[19:39:34] fail: [FAIL] System.Diagnostics.Tests.StackFrameTests.Ctor_Filename_LineNumber(fileName: "", lineNumber: 0)
[19:39:34] info: Expected GetILOffset() -1 for <null>
[19:39:34] info:  to be greater or equal to zero.
[19:39:34] info: Expected: True
[19:39:34] info: Actual:   False
[19:39:34] info: 
[19:39:34] fail: [FAIL] System.Diagnostics.Tests.StackFrameTests.Ctor_Filename_LineNumber(fileName: "FileName", lineNumber: 1)
[19:39:34] info: Expected GetILOffset() -1 for <null>
[19:39:34] info:  to be greater or equal to zero.
[19:39:34] info: Expected: True
[19:39:34] info: Actual:   False

Activity

  1. radical
    added
    arch-wasmWebAssembly architecture
    area-Codegen-AOT-mono
    wasm-aot-testWebAssembly AOT Test
    on Apr 8, 2021
  3. ghost added
    untriagedNew issue has not been triaged by the area owner
    on Apr 8, 2021
  4. SamMonoRT
    added this to the 6.0.0 milestone on Apr 9, 2021
  5. BrzVlad
    self-assigned this
    on May 5, 2021

  6. BrzVlad commented on May 7, 2021

    @BrzVlad
    BrzVlad
    on May 7, 2021
    Member

    I don't see how it would be possible to implement this, unless we would be manually linking frames with each call, which sounds like a bad idea.

  7. lewing commented on May 7, 2021

    @lewing
    lewing
    on May 7, 2021
    Member

    yeah I think we should probably just skip these with platform detection on AOT

  8. radical commented on May 7, 2021

    @radical
    radical
    on May 7, 2021
    MemberAuthor

    Only the failing tests, or the entire library?

  9. lewing commented on May 7, 2021

    @lewing
    lewing
    on May 7, 2021
    Member

    Don't skip the library. Leave them active issue for now. We may want to consider an AOT analyzer for cases like this too. Thoughts @marek-safar

  10. lewing
    removed
    untriagedNew issue has not been triaged by the area owner
    on May 7, 2021
  11. radical
    changed the title [-][wasm][tests][aot] System.Diagnostics.StackTrace[/-] [+][wasm][tests][aot] Stacktrace not supported: `System.Diagnostics.StackTrace`[/+] on Jun 15, 2021
  12. radical
    changed the title [-][wasm][tests][aot] Stacktrace not supported: `System.Diagnostics.StackTrace`[/-] [+][wasm][tests][aot] Tests failing due to stacktrace not supported[/+] on Jun 16, 2021

  13. radical commented on Jun 16, 2021

    @radical
    radical
    on Jun 16, 2021
    MemberAuthor

    Merging #51676 with this.

    Instead of the crash, we have one test failure now:

[22:22:31] fail: [FAIL] System.Tests.EnvironmentStackTrace.StackTraceDoesNotStartWithInternalFrame
[22:22:31] info: System.NullReferenceException : Object reference not set to an instance of an object.
[22:22:31] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )

  14. BrzVlad commented on Jun 29, 2021

    @BrzVlad
    BrzVlad
    on Jun 29, 2021
    Member

    Having stack traces on wasm is a bit complicated and I think we should revisit this for .net 7. @lewing Any thoughts on moving the milestone ?

  15. SamMonoRT
    modified the milestones: 6.0.0, 7.0.0 on Jul 16, 2021

  16. SamMonoRT commented on Jul 16, 2021

    @SamMonoRT
    SamMonoRT
    on Jul 16, 2021
    Member

    Moving to 7.0.0

  17. ilonatommy commented on Jun 15, 2022

    @ilonatommy
    ilonatommy
    on Jun 15, 2022
    Member

    @BrzVlad, did you hit into any blocker in the part of #63399 targeting prev 2?

  18. BrzVlad commented on Jun 15, 2022

    @BrzVlad
    BrzVlad
    on Jun 15, 2022
    Member

    @BrzVlad, did you hit into any blocker in the part of #63399 targeting prev 2?

    That approach was abandoned. I'm not sure what is the best way to support stack traces with wasm code, maybe there will be some additions to the spec that will allow to implement this more easily.

  19. lewing
    modified the milestones: 7.0.0, Future on Jun 15, 2022

  20. lewing commented on Jun 16, 2022

    @lewing
    lewing
    on Jun 16, 2022
    Member

    we're getting enough diagnostic info from the current stacks that this isn't urgent, we'll go over it again when planning for 8

  21. pavelsavara commented on Apr 22, 2026

    @pavelsavara
    pavelsavara
    on Apr 22, 2026
    Member

    For coreCLR this may be solved by enabling <StackTraceLineNumberSupport>true</StackTraceLineNumberSupport> for the tests.

  22. maraf
    added a commit that references this issue on Apr 24, 2026

    Enable StackTrace tests on browser now that line number support is en…

    6ce3ebe
  23. lewing
    added
    disabled-testThe test is disabled in source code against the issue
    on Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

arch-wasmWebAssembly architecturearea-Codegen-AOT-monodisabled-testThe test is disabled in source code against the issuewasm-aot-testWebAssembly AOT Test

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions