Repository navigation
System.Net.Http.Functional.Tests crashing on Debian10 #48106
Description
./RunTests.sh: line 162: 23 Segmentation fault (core dumped) "$RUNTIME_PATH/dotnet" exec --runtimeconfig System.Net.Http.Functional.Tests.runtimeconfig.json --depsfile System.Net.Http.Functional.Tests.deps.json xunit.console.dll System.Net.Http.Functional.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing $RSP_FILE
/root/helix/work/workitem
----- end Wed 10 Feb 2021 01:03:19 PM UTC ----- exit code 139 ----------------------------------------------------------
exit code 139 means SIGSEGV Illegal memory access. Deref invalid pointer, overrunning buffer, stack overflow etc. Core dumped.
cc @dotnet/ncl
Activity
ManickaP commentedon Feb 10, 2021
I'm looking.
ManickaP commentedon Feb 12, 2021
Should be fixed with #48193
stephentoub commentedon Feb 12, 2021
But we're still going to follow-up to understand and fix why it impacted SslStream, right? It seems there's a deeper issue lurking and potentially triggering exceptions unexpectedly.
ManickaP commentedon Feb 12, 2021
If I get it right, it impacted
SslStreambecause it depends onSafeHandleguarding against passing nulls to P/Invokes. To fix it, we would need add our own checks before every P/Invoke.If you're talking about
SslStreambeing disposed from one thread while being written to from another, that's a thing we use a lot in HttpClient (disposing stream in case of cancellation/timeout etc.) and that would require non-trivial changes.But I might be missing the point you're trying to push us to 😄 Maybe @wfurt is better to answer your questions 😄
stephentoub commentedon Feb 16, 2021
We would fix whatever race is leading to us trying to use a null SafeHandle.
Exactly, which means we're potentially triggering a bunch of exceptions that a) we didn't intend to and could lead to functional problems and b) could be adding non-trivial overheads.