Skip to content

Some .c and .h files are being published for non-blazorwasm apps #48016

Closed
Closed
Some .c and .h files are being published for non-blazorwasm apps#48016
Assignees
radicalmaraf
Labels
arch-wasmWebAssembly architecturearea-Build-mono
Milestone
8.0.0

Description

@eerhardt
eerhardt
opened on Feb 8, 2021
  1. Install the latest https://github.com/dotnet/installer#installers-and-binaries
  2. dotnet new blazorwasm
  3. dotnet publish -c Release

Expected Results

Only the files necessary to load the blazor app are in the publish folder

Actual Results

There are 3 .c files and 2 .h files in bin\Release\net6.0\publish\wwwroot\_framework:

  • corebindings.c
  • driver.c
  • pinvoke.c
  • pinvoke.h
  • pinvoke-table.h

image

These files shouldn't be published to the output folder.

cc @lewing @CoffeeFlux

Activity

  1. eerhardt
    added
    arch-wasmWebAssembly architecture
    on Feb 8, 2021
  3. ghost added
    area-Setup
    on Feb 8, 2021
  4. ghost added
    untriagedNew issue has not been triaged by the area owner
    on Feb 8, 2021
  5. eerhardt
    added
    area-Interop-mono
    and removed
    area-Setup
    on Feb 8, 2021
  6. lewing
    assigned
    radical
    on Feb 8, 2021
  7. lewing
    removed
    untriagedNew issue has not been triaged by the area owner
    on Feb 8, 2021
  8. lewing
    added this to the 6.0.0 milestone on Feb 8, 2021

  9. am11 commented on Feb 9, 2021

    @am11
    am11
    on Feb 9, 2021
    Member

    This seems to be intentional: #43785 (review). I think if we don't need the intermediate files, one cleaner option is that we separate out the "runtime pack with intermediates" from "standard runtime pack" (as the former is not for the common use-case for end-users, and requires WebAssembly compiler toolchain to be installed; to be able to relink with different arguments).

    e.g. ./build.sh -os browser -c Release will not put these intermediate artifacts in artifacts//bin/native/net6.0-Browser-Release-wasm/src/, but, say a new OS, ./build.sh -os browser-extras -c Release will. This way, we will not need to modify src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props, as that is a flat whitelist of 'all possible files' and sfx targets (in arcade) validate the other way around; all files in destination directory (in this case artifacts//bin/native/net6.0-Browser-Release-wasm/src/) are present in the whitelist. So if a subset (like clr or mono) doesn't produce all those files, it is fine.

    cc @vargaz

    BTW, here is the complete diff between net5 and net6 (6.0.0-preview.2.21105.12; 0429344) wwwroot/_framework directories:

    --- net5
+++ net6
 System.Runtime.CompilerServices.Unsafe.dll
 System.Runtime.CompilerServices.Unsafe.dll.br
 System.Runtime.CompilerServices.Unsafe.dll.gz
-System.Runtime.InteropServices.RuntimeInformation.dll
-System.Runtime.InteropServices.RuntimeInformation.dll.br
-System.Runtime.InteropServices.RuntimeInformation.dll.gz
 System.Text.Encodings.Web.dll
 System.Text.Encodings.Web.dll.br
 System.Text.Encodings.Web.dll.gz
 System.Text.Json.dll
 System.Text.Json.dll.br
 System.Text.Json.dll.gz
+binding_support.js
+binding_support.js.br
+binding_support.js.gz
 blazor.boot.json
 blazor.boot.json.br
 blazor.boot.json.gz
@@ -106,15 +106,30 @@
 my-blazor-app.dll
 my-blazor-app.dll.br
 my-blazor-app.dll.gz
-dotnet.5.0.0.js
-dotnet.5.0.0.js.br
-dotnet.5.0.0.js.gz
+corebindings.c
+corebindings.c.br
+corebindings.c.gz
+dotnet.6.0.0-preview.2.21105.12.js
+dotnet.6.0.0-preview.2.21105.12.js.br
+dotnet.6.0.0-preview.2.21105.12.js.gz
 dotnet.timezones.blat
 dotnet.timezones.blat.br
 dotnet.timezones.blat.gz
 dotnet.wasm
 dotnet.wasm.br
 dotnet.wasm.gz
+dotnet_support.js
+dotnet_support.js.br
+dotnet_support.js.gz
+driver.c
+driver.c.br
+driver.c.gz
+emcc-flags.txt
+emcc-flags.txt.br
+emcc-flags.txt.gz
+emcc-version.txt
+emcc-version.txt.br
+emcc-version.txt.gz
 icudt.dat
 icudt.dat.br
 icudt.dat.gz
@@ -127,3 +142,18 @@
 icudt_no_CJK.dat
 icudt_no_CJK.dat.br
 icudt_no_CJK.dat.gz
+library_mono.js
+library_mono.js.br
+library_mono.js.gz
+pal_random.js
+pal_random.js.br
+pal_random.js.gz
+pinvoke-table.h
+pinvoke-table.h.br
+pinvoke-table.h.gz
+pinvoke.c
+pinvoke.c.br
+pinvoke.c.gz
+pinvoke.h
+pinvoke.h.br
+pinvoke.h.gz

  10. vargaz commented on Feb 9, 2021

    @vargaz
    vargaz
    on Feb 9, 2021
    Contributor

    We need those files to compile the final dotnet executable, at least driver.c needs to stay a source file since its compiled with -D defines during the build. Maybe we can get them from the runtime pack instead of the publish dir. Not sure how they end up in the final app, we create the final app ourself in the bin/Release/AppBundle directory which doesn't contain these files.

  11. am11 commented on Feb 11, 2021

    @am11
    am11
    on Feb 11, 2021
    Member

    Looks like in https://github.com/dotnet/sdk/blob/9ccce1ee9788b8267e0242f73b74bf9766bb20d0/src/BlazorWasmSdk/Targets/Microsoft.NET.Sdk.BlazorWebAssembly.Current.targets, due to line 95 and line 211, everything under ~/.nuget/packages/microsoft.netcore.app.runtime.browser-wasm/6.0.0-preview.2.21105.12/runtimes/browser-wasm/native gets copied to publish dir's wwwroot/_framework/. We can copy these additional *.c and *.h files somewhere else, say runtimes/browser-wasm/sources instead of runtimes/browser-wasm/native in this package without changing the SDK. Would that work?

    Also, (unless it was intentional) the missing System.Runtime.InteropServices.RuntimeInformation.dll from .NET6 publish directory could be problematic.

  12. eerhardt commented on Feb 11, 2021

    @eerhardt
    eerhardt
    on Feb 11, 2021
    MemberAuthor

    Also, (unless it was intentional) the missing System.Runtime.InteropServices.RuntimeInformation.dll from .NET6 publish directory could be problematic.

    It isn't problematic. This assembly is no longer necessary. In net5.0, AspNetCore.Components was using the RuntimeInformation.IsOSPlatform method from this assembly. In net6.0, that code has been changed to use the new OperatingSystem.IsXXX() methods. See dotnet/aspnetcore#28233.

  13. pranavkm commented on Feb 13, 2021

    @pranavkm
    pranavkm
    on Feb 13, 2021
    Contributor

    By the way, we could change the SDK to have be more deliberate about what files are included (.dat, .blat, and the dotnet.wasm file). The SDK's globbing is very permissive today and there's no reason we couldn't flip it around

  14. eerhardt commented on Feb 13, 2021

    @eerhardt
    eerhardt
    on Feb 13, 2021
    MemberAuthor

    The SDK's globbing is very permissive today and there's no reason we couldn't flip it around

    I believe this is intentional with the reasoning being that the runtime gets to pick what is and what isn't included in the output of the application. If the file is in the right directory of the runtimepack, the intention is it is needed at runtime.

    We had similar conversations about .a files and removed them in #41966.

  15. 9 remaining items

  16. eerhardt commented on May 17, 2021

    @eerhardt
    eerhardt
    on May 17, 2021
    MemberAuthor

    FYI - this was also logged in ASP.NET - dotnet/aspnetcore#32744.

  17. marek-safar
    added
    area-Build-mono
    and removed
    area-Interop-mono
    on Jun 2, 2021

  18. radical commented on Sep 9, 2021

    @radical
    radical
    on Sep 9, 2021
    Member

    This is not an issue for blazorwasm projects anymore, as it is skipping those files. So, moving this to 7.0.0, to fix for non-blazorwasm projects.

  19. radical
    modified the milestones: 6.0.0, 7.0.0 on Sep 9, 2021
  20. radical
    changed the title [-]Some .c and .h files are being published for Blazor WASM apps[/-] [+]Some .c and .h files are being published for non-blazorwasm apps[/+] on Sep 9, 2021

  21. lewing commented on May 12, 2022

    @lewing
    lewing
    on May 12, 2022
    Member

    We need to decide on a resolution to this so that the various bundlers can share it.

  22. radical commented on Aug 10, 2022

    @radical
    radical
    on Aug 10, 2022
    Member

    This is being handled currently, but in a hacky manner. And we have an approach in mind, but that will get implemented in .net8 .

  23. radical
    modified the milestones: 7.0.0, 8.0.0 on Aug 10, 2022
  24. lewing
    assigned
    maraf
    on Jul 24, 2023

  25. maraf commented on Jul 24, 2023

    @maraf
    maraf
    on Jul 24, 2023
    Member

    This is resolved in Wasm SDK

  26. maraf
    closed this as completedon Jul 24, 2023
  27. ghost locked as resolved and limited conversation to collaborators on Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions