Repository navigation
System.Runtime.InteropServices.RuntimeInformation.FrameworkDescription for stable servicing releases includes the full build information in the version suffix #45812
Description
Description
Using the just released 5.0.1 runtime, the System.Runtime.InteropServices.RuntimeInformation.FrameworkDescription API is returning the string ".NET 5.0.1-servicing.20575.16". The issue reproduces on Windows during local dev on a framework-dependent app, and after deployment when running on Linux as a self-contained app.
Repro
Call the System.Runtime.InteropServices.RuntimeInformation.FrameworkDescription API in an app targeting net5.0 on a machine with the .NET 5.0.1 runtime installed.
Expected
Calling the System.Runtime.InteropServices.RuntimeInformation.FrameworkDescription API should return a description with stable versions for stable servicing releases, e.g. ".NET 5.0.1".
Actual
Using the just released 5.0.1 runtime, calling the System.Runtime.InteropServices.RuntimeInformation.FrameworkDescription API is returning the string ".NET 5.0.1-servicing.20575.16", which includes an unstable/preview version suffix.
Activity
jkotas commentedon Dec 9, 2020
@Anipik @safern This API returns the product version string of System.Private.CoreLib. Is it expected that the product version string for 5.0.1 includes the unstable/preview version suffix?
safern commentedon Dec 9, 2020
It shouldn't. I can take a look tomorrow to see why the version was wrong.
DamianEdwards commentedon Mar 9, 2021
Is this fixed now?
safern commentedon Mar 9, 2021
Yeah this was fixed on: #45876. However I need to add tests for it to avoid regressing again.
deeprobin commentedon Sep 3, 2021
@safern What is the current status of this?
safern commentedon Sep 28, 2021
We are still missing tests for this.
4 remaining items
DamianEdwards commentedon Nov 5, 2021
FYI seems we meant to take this for GA but it slipped through the cracks #60572 (comment)
safern commentedon Nov 8, 2021
I will work on adding tests for this on 7.0 so that this doesn't happen again.
mairaw commentedon Nov 29, 2021
So is the fix going to make into 6.0.1? Just wondering if I need to have a workaround in place so we don't show an ugly version on the dot.net website as I reported on #61394. If it's just a few more days, I can wait.
jeffhandley commentedon Jul 10, 2022
7 months later...
We don't have the work for this scheduled yet. Moving to Future. I don't know if a workaround is already in place though.
akoeplinger commentedon Oct 24, 2023
This was fixed by #60572 and backported to 6.0. I verified that we return the correct stabilized version in net6.0, net7.0 and net8.0.
We also have indirect tests for this as was surfaced by #93807 but I think adding a simple unit test shouldn't be much work, I'll open a PR for that.
Add RuntimeInformation.FrameworkDescription test to validate version
Add RuntimeInformation.FrameworkDescription test to validate version (#…
Add RuntimeInformation.FrameworkDescription test to validate version (d…