Repository navigation
Breaking change in ResourceSet class #44483
Description
This PR #44104 introduces a breaking change that is only experienced at runtime.
ResourceSet implements IEnumerable and ASP.NET Core is using the contract.
At least there, but other tests break so it might not be isolated.
https://github.com/dotnet/aspnetcore/blob/master/src/Localization/Localization/src/Internal/ResourceManagerStringProvider.cs#L75
While we could react to this change, it doesn't seem that this change of behavior was intentional.
Activity
jkotas commentedon Nov 10, 2020
Revert in #44482
marek-safar commentedon Nov 10, 2020
@sebastienros what is the failure?
sebastienros commentedon Nov 10, 2020
I left all the details on the PR. To summarize
ResourceSetimplementsIEnumerablebut the returned elements are not of the same type. They wereDictionaryEntryand now they areKeyValuePair<>.tarekgh commentedon Nov 10, 2020
@marek-safar here is @sebastienros comment regarding the failure #44104 (comment)
marek-safar commentedon Nov 10, 2020
I see you are casting object to underlying type. That needs to be fixed on runtime side.
tarekgh commentedon Nov 10, 2020
@marek-safar just to make sure you saw @jkotas PR reverting your change which broke this scenario #44482
marek-safar commentedon Nov 10, 2020
Yep, let's revert this to unblock them. I'll fix that in follow up PR (revert)