Adding assembly level UnsupportedOSPlatform("browser") System.Security.Cryptography.Primitives is not correct, HashAlgorithm supported on browser #43380

Activity

1. jeffhandley

   added

   arch-wasmWebAssembly architectureWebAssembly architecture

   area-System.Security

   untriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner

   on Oct 14, 2020
3. lewing commented on Oct 14, 2020

   

   lewing

   on Oct 14, 2020

   Member

   More actions

   HashAlgorithm and HashAlgorithmName are currently marked as unsupported on browser but are available for use. Absent a compelling reason I don't think we should annotate the other primitives that don't include any implementation as unsupported either.

   /cc @steveisok @marek-safar
4. lewing

   assigned

   kjpou1

   on Oct 14, 2020
5. kjpou1 commented on Oct 14, 2020

   

   kjpou1

   on Oct 14, 2020

   Last edited by kjpou1

   Contributor

   More actions

   From my understanding of the Primitives they are there for use of the other Cryptography modules without specific implementations so can be available for use as well.
6. lewing

   added this to the 5.0.0 milestone on Oct 14, 2020
7. lewing commented on Oct 14, 2020

   

   lewing

   on Oct 14, 2020

   Last edited by lewing

   Member

   More actions

   @kjpou1 please review the primitive classes, especially where they are base classes, and correct the platform annotations.
8. kjpou1 commented on Oct 14, 2020

   

   kjpou1

   on Oct 14, 2020

   Contributor

   More actions

   This should be only needed to remove the os platform not supported. The classes are abstract and implemented in the other cryptography modules.

   👍React with 👍2Reacted by Jeff Handley and Larry Ewing
9. lewing

   removed

   untriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner

   on Oct 14, 2020
10. akoeplinger commented on Oct 14, 2020

    

    akoeplinger

    on Oct 14, 2020

    Member

    More actions

    Shouldn't we still mark the static methods on some of these classes as unsupported that we know don't work:

    namespace System.Security.Cryptography
    {
        public abstract partial class AsymmetricAlgorithm : System.IDisposable
        {
            public static System.Security.Cryptography.AsymmetricAlgorithm Create() { throw null; }
            public static System.Security.Cryptography.AsymmetricAlgorithm? Create(string algName) { throw null; }
        }
        public abstract partial class HMAC : System.Security.Cryptography.KeyedHashAlgorithm
        {
            public static new System.Security.Cryptography.HMAC Create() { throw null; }
            public static new System.Security.Cryptography.HMAC? Create(string algorithmName) { throw null; }
        }
        public abstract partial class KeyedHashAlgorithm : System.Security.Cryptography.HashAlgorithm
        {
            public static new System.Security.Cryptography.KeyedHashAlgorithm Create() { throw null; }
            public static new System.Security.Cryptography.KeyedHashAlgorithm? Create(string algName) { throw null; }
        }
        public abstract partial class SymmetricAlgorithm : System.IDisposable
        {
            public static System.Security.Cryptography.SymmetricAlgorithm Create() { throw null; }
            public static System.Security.Cryptography.SymmetricAlgorithm? Create(string algName) { throw null; }
        }
    }
11. lewing commented on Oct 14, 2020

    

    lewing

    on Oct 14, 2020

    Last edited by lewing

    Member

    More actions

    @akoeplinger that is an interesting question. Create() on all those classes is marked Obsolete and throw PNSE unconditionally on all platforms already
    

    runtime/src/libraries/System.Security.Cryptography.Primitives/src/System/Security/Cryptography/AsymmetricAlgorithm.cs

    Line 17 in 2ca0b93

    public static AsymmetricAlgorithm Create() =>

    Create(string name) should probably be marked but the code is written such that HashAlgorithm.Create(string name) could try to create a KeyedHashAlgorithm.
12. kjpou1

    closed this as completedin #43387on Oct 15, 2020
13. ghost locked as resolved and limited conversation to collaborators on Dec 7, 2020