Skip to content

Provide offset to placeholder in apphost pack #3829

Closed

Description

@nguerrera

Today, the SDK does a search and replace in the apphost, to find the placeholder. However, the offset to the placeholder is fixed for any given apphost pack. It would be cleaner if this offset could be determined when the apphost template is built and described in a simple sidecar file.

The code that does the search fails on some filesystems today, due to MAP_SHARED not being implemented. We could implement the search a different way, but risk regressing perf for an operation that needn't be done on every end-user's build, and can be done once in our build.

cc @peterhuene @swaroop-sridhar @jeffschwMSFT

Activity

  1. nguerrera commented on Nov 4, 2019

    @nguerrera
    ContributorAuthor

    The idea of providing the offset was raised in the initial PR that implemented search and replace: dotnet/sdk#978 (comment)

    We were missing the additional data point that the memory mapped code would fail on some filesystems, though.

  2. transferred this issue fromdotnet/core-setupon Jan 30, 2020
  3. added this to the 5.0 milestone on Jan 30, 2020
  4. removed
    untriagedNew issue has not been triaged by the area owner
    on Feb 24, 2020
  5. modified the milestones: 5.0.0, 6.0.0 on Jun 26, 2020
  6. removed their assignment
    on Sep 8, 2020
  7. modified the milestones: 6.0.0, Future on Aug 10, 2021
  8. dotnet-policy-service commented on Feb 9, 2026

    @dotnet-policy-service
    Contributor

    Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.

    This process is part of our issue cleanup automation.

  9. dotnet-policy-service commented on Feb 23, 2026

    @dotnet-policy-service
    Contributor

    This issue will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the issue, but please note that the issue will be locked if it remains inactive for another 30 days.

  10. removed this from the Future milestone on Feb 23, 2026
  11. locked and limited conversation to collaborators on Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions