Skip to content

JIT: consider running throw helper merge pass earlier #35135

Closed
#35255
Closed
JIT: consider running throw helper merge pass earlier#35135
#35255
Labels
area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIenhancementProduct code improvement that does NOT require public API changes/additionsoptimization
Milestone
5.0.0

Description

@AndyAyersMS
AndyAyersMS
opened on Apr 17, 2020

We currently run this after morph, but call morphing can introduce new temps that can introduce diffs between otherwise identical call sequences.

When this phase was introduced I wanted to run it before morph but wasn't able to because we lacked control flow information; now with #1309 we can probably run it pre-morph.

See dotnet/aspnetcore#20885 for one such example.

Activity

  1. AndyAyersMS
    added
    enhancementProduct code improvement that does NOT require public API changes/additions
    area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
    optimization
    on Apr 17, 2020
  2. AndyAyersMS
    added this to the 5.0 milestone on Apr 17, 2020
  3. Dotnet-GitSync-Bot
    added
    untriagedNew issue has not been triaged by the area owner
    on Apr 17, 2020
  4. BruceForstall
    removed
    untriagedNew issue has not been triaged by the area owner
    on Apr 20, 2020
  5. AndyAyersMS
    added a commit that references this issue on Apr 21, 2020

    Jit: run throw helper merge phase before morph

    1160f96
  6. AndyAyersMS
    closed this as completedin #35255on Apr 23, 2020
  7. AndyAyersMS
    added a commit that references this issue on Apr 23, 2020

    Jit: run throw helper merge phase before morph (#35255)

    b828309
  8. ghost locked as resolved and limited conversation to collaborators on Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIenhancementProduct code improvement that does NOT require public API changes/additionsoptimization

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions