Skip to content

The x86 path for UnmanagedCallersOnlyAttribute should be improved. #33582

Closed
Closed
The x86 path for UnmanagedCallersOnlyAttribute should be improved.#33582
Labels
area-Interop-coreclr
Milestone
6.0.0

Description

@AaronRobinsonMSFT
AaronRobinsonMSFT
opened on Mar 14, 2020

The making public of NativeCallableAttribute UnmanagedCallersOnlyAttribute done in #33005, provided some additional optimizations. However the Windows-x86 path was deemed lower priority so wasn't optimized. There are various locations where the Windows-x86 platform opted out of the optimization.

Examples:

runtime/src/coreclr/src/vm/jitinterface.cpp

Lines 9212 to 9224 in a1af0f2

#if defined(TARGET_X86) && defined(TARGET_WINDOWS) && !defined(CROSSGEN_COMPILE)
// Deferring X86 support until a need is observed or
// time permits investigation into all the potential issues.
if (pMD->HasNativeCallableAttribute())
{
pResult->addr = (void*)COMDelegate::ConvertToCallback(pMD);
}
else
{
pResult->addr = (void*)pMD->GetMultiCallableAddrOfCode();
}
#else

runtime/src/coreclr/src/vm/jitinterface.cpp

Lines 12389 to 12392 in a1af0f2

#if !defined(TARGET_X86) || !defined(TARGET_WINDOWS)
if (ftn->HasNativeCallableAttribute())
flags.Set(CORJIT_FLAGS::CORJIT_FLAG_REVERSE_PINVOKE);
#endif // !TARGET_X86 || !TARGET_WINDOWS

runtime/src/coreclr/src/tools/Common/JitInterface/CorInfoImpl.cs

Lines 2887 to 2891 in a1af0f2

if (targetArchitecture == TargetArchitecture.X86
&& _compilation.TypeSystemContext.Target.OperatingSystem == TargetOS.Windows)
{
throw new RequiresRuntimeJitException("ReadyToRun: Methods with NativeCallableAttribute not implemented");
}

runtime/src/coreclr/src/tools/crossgen2/ILCompiler.ReadyToRun/JitInterface/CorInfoImpl.ReadyToRun.cs

Lines 1663 to 1669 in a1af0f2

var targetDetails = _compilation.TypeSystemContext.Target;
if (targetDetails.Architecture == TargetArchitecture.X86
&& targetDetails.OperatingSystem == TargetOS.Windows
&& targetMethod.IsNativeCallable)
{
throw new RequiresRuntimeJitException("ReadyToRun: References to methods with NativeCallableAttribute not implemented");
}

Activity

  1. AaronRobinsonMSFT
    added
    area-Interop-coreclr
    untriagedNew issue has not been triaged by the area owner
    on Mar 14, 2020
  2. jkotas
    changed the title [-]The Windows x86 path for NativeCallableAttribute should be improved.[/-] [+]The x86 path for NativeCallableAttribute should be improved.[/+] on Mar 29, 2020

  3. jkotas commented on Mar 29, 2020

    @jkotas
    jkotas
    on Mar 29, 2020
    Member

    Generalizing the issue to both Windows and Linux. It turns our both Windows x86 and Linux x86 need work.

  4. AaronRobinsonMSFT commented on Mar 30, 2020

    @AaronRobinsonMSFT
    AaronRobinsonMSFT
    on Mar 30, 2020
    MemberAuthor

    See #34251 (comment) for Linux x86 issues.

  5. jeffschwMSFT
    removed
    untriagedNew issue has not been triaged by the area owner
    on Apr 2, 2020
  6. jeffschwMSFT
    added this to the 5.0 milestone on Apr 2, 2020

  7. jkotas commented on Apr 6, 2020

    @jkotas
    jkotas
    on Apr 6, 2020
    Member

    See #34548 for (subset of) places that are affected.

  8. AaronRobinsonMSFT
    changed the title [-]The x86 path for NativeCallableAttribute should be improved.[/-] [+]The x86 path for UnmanagedCallersOnlyAttribute should be improved.[/+] on May 3, 2020
  9. elinor-fung
    modified the milestones: 5.0.0, 6.0.0 on Aug 12, 2020

  10. AaronRobinsonMSFT commented on Dec 5, 2020

    @AaronRobinsonMSFT
    AaronRobinsonMSFT
    on Dec 5, 2020
    MemberAuthor

    @jkoritzinsky I assume some of the work you are doing is addressing this.

  11. jkoritzinsky commented on Dec 5, 2020

    @jkoritzinsky
    jkoritzinsky
    on Dec 5, 2020
    Member

    Kind of. I’ll make sure to link to this issue as I do the work related to it.

  12. ghost added
    in-prThere is an active PR which will close this issue when it is merged
    on Dec 19, 2020
  13. ghost removed
    in-prThere is an active PR which will close this issue when it is merged
    on Jan 20, 2021

  14. jkoritzinsky commented on Apr 5, 2021

    @jkoritzinsky
    jkoritzinsky
    on Apr 5, 2021
    Member

    Fixed by #46238

  15. jkoritzinsky
    closed this as completedon Apr 5, 2021
  16. ghost locked as resolved and limited conversation to collaborators on May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-Interop-coreclr

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions